fix: Do not release mutex for printing log message

ligato · Mar 12, 2021 · 82ffc0b · 82ffc0b
1 parent fd54fd6
commit 82ffc0b
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/plugins/vpp/ifplugin/interface_state.go b/plugins/vpp/ifplugin/interface_state.go
@@ -248,20 +248,18 @@ func (c *InterfaceStateUpdater) doUpdatesIfStateDetails() {
 		return
 	}
 
-	// we dont want to lock during potentionally long dump call
-	c.access.Unlock()
-
 	c.log.Debugf("updating interface states for %d interfaces", len(c.ifsForUpdate))
 
 	var ifIdxs []uint32
-	c.access.Lock()
 	if len(c.ifsForUpdate) < 1000 {
 		for ifIdx := range c.ifsForUpdate {
 			ifIdxs = append(ifIdxs, ifIdx)
 		}
 	}
 	// clear interfaces for update
 	c.ifsForUpdate = make(map[uint32]struct{})
+
+	// we dont want to lock during potentionally long dump call
 	c.access.Unlock()
 
 	ifaces, err := c.ifHandler.DumpInterfaceStates(ifIdxs...)