-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate CI to Github Large Runner #309
Conversation
See the diff generated by this PR for the tests here: https://github.com/lifting-bits/rellic/actions/runs/3313437158 fizzbuzz.bctypedefs_of_typedefs.bcswitch_loop.bcfunc_cond_zero_arg.bcfcmp.bcconflicting_names.bcstruct.bcissue_183_literal_structs.bczeroinit.bcissue_127_uint128_t_lit.bcstruct_swap.bcglobal_using_function_decl.bcinit_list.bcreg_test_structure_fields.bcret0.bcgoto_loop.bcbool.bcbitops.bccast.bcnullptr.bcnested_struct.bcarray_swap.bcbinops.bcbitmask.bcloop.bcfloat.bcvectors.bcfuncptr.bcinttoptr.bcshort.bctrunc.bcissue_4.bcconflicting_global.bcissue_123_uint128_t.bcfizzbuzz_stateful.bcissue_94_strncmp.bczext.bcbyval_struct.bcnested_while.bc--- /dev/fd/63 2022-10-24 14:19:07.518746030 +0000
+++ /dev/fd/62 2022-10-24 14:19:07.522746094 +0000
@@ -18,14 +18,14 @@
printf("loop1 x: %d\n", var1);
}
}
- if ((int)var1 >= 20 || (int)var1 <= 10) {
+ if ((int)var1 <= 10 || (int)var1 >= 20) {
while ((int)var1 < 20)
{
var1 = var1 + 1U;
printf("loop2 x: %d\n", var1);
}
}
- if ((int)var1 >= 20 && ((int)var1 >= 20 || (int)var1 <= 10)) {
+ if ((int)var1 >= 20 && ((int)var1 <= 10 || (int)var1 >= 20)) {
return var0;
}
} func_cond_two_arg.bcassert.bcswitch.bcbranch.bctemplate_parameter_pack.bcbyval_tail_nogep.llbyval_tail_gep.ll |
See the diff generated by this PR for the tests here: https://github.com/lifting-bits/rellic/actions/runs/3314458380 fizzbuzz.bc--- /dev/fd/63 2022-10-24 16:32:56.002768545 +0000
+++ /dev/fd/62 2022-10-24 16:32:56.002768545 +0000
@@ -11,7 +11,7 @@
var1 = 0U;
while ((int)var1 < 30)
{
- if ((int)var1 % 3 != 0U || !((int)var1 % 3 != 0U || (int)var1 % 5 == 0U)) {
+ if (!((int)var1 % 5 == 0U || (int)var1 % 3 != 0U) || (int)var1 % 3 != 0U) {
if ((int)var1 % 3 != 0U) {
if ((int)var1 % 5 != 0U) {
printf("%d\n", var1); typedefs_of_typedefs.bcswitch_loop.bcfunc_cond_zero_arg.bcfcmp.bcconflicting_names.bcstruct.bcissue_183_literal_structs.bczeroinit.bcissue_127_uint128_t_lit.bcstruct_swap.bcglobal_using_function_decl.bcinit_list.bcreg_test_structure_fields.bcret0.bcgoto_loop.bcbool.bcbitops.bccast.bcnullptr.bcnested_struct.bcarray_swap.bcbinops.bcbitmask.bcloop.bcfloat.bcvectors.bcfuncptr.bcinttoptr.bcshort.bctrunc.bcissue_4.bcconflicting_global.bcissue_123_uint128_t.bcfizzbuzz_stateful.bcissue_94_strncmp.bczext.bcbyval_struct.bcnested_while.bcfunc_cond_two_arg.bcassert.bcswitch.bcbranch.bctemplate_parameter_pack.bcbyval_tail_nogep.llbyval_tail_gep.ll |
See the diff generated by this PR for the tests here: https://github.com/lifting-bits/rellic/actions/runs/3314492638 fizzbuzz.bctypedefs_of_typedefs.bcswitch_loop.bcfunc_cond_zero_arg.bcfcmp.bcconflicting_names.bcstruct.bcissue_183_literal_structs.bczeroinit.bcissue_127_uint128_t_lit.bcstruct_swap.bcglobal_using_function_decl.bcinit_list.bcreg_test_structure_fields.bcret0.bcgoto_loop.bcbool.bcbitops.bccast.bcnullptr.bcnested_struct.bcarray_swap.bcbinops.bcbitmask.bcloop.bcfloat.bcvectors.bcfuncptr.bcinttoptr.bcshort.bctrunc.bcissue_4.bcconflicting_global.bcissue_123_uint128_t.bcfizzbuzz_stateful.bcissue_94_strncmp.bczext.bcbyval_struct.bcnested_while.bc--- /dev/fd/63 2022-10-24 16:37:53.600835764 +0000
+++ /dev/fd/62 2022-10-24 16:37:53.600835764 +0000
@@ -18,14 +18,14 @@
printf("loop1 x: %d\n", var1);
}
}
- if ((int)var1 >= 20 || (int)var1 <= 10) {
+ if ((int)var1 <= 10 || (int)var1 >= 20) {
while ((int)var1 < 20)
{
var1 = var1 + 1U;
printf("loop2 x: %d\n", var1);
}
}
- if ((int)var1 >= 20 && ((int)var1 >= 20 || (int)var1 <= 10)) {
+ if ((int)var1 >= 20 && ((int)var1 <= 10 || (int)var1 >= 20)) {
return var0;
}
} func_cond_two_arg.bcassert.bcswitch.bcbranch.bctemplate_parameter_pack.bcbyval_tail_nogep.llbyval_tail_gep.ll |
See the diff generated by this PR for the tests here: https://github.com/lifting-bits/rellic/actions/runs/3314555205 fizzbuzz.bctypedefs_of_typedefs.bcswitch_loop.bcfunc_cond_zero_arg.bcfcmp.bcconflicting_names.bcstruct.bcissue_183_literal_structs.bczeroinit.bcissue_127_uint128_t_lit.bcstruct_swap.bcglobal_using_function_decl.bcinit_list.bcreg_test_structure_fields.bcret0.bcgoto_loop.bcbool.bcbitops.bccast.bcnullptr.bcnested_struct.bcarray_swap.bcbinops.bcbitmask.bcloop.bcfloat.bcvectors.bcfuncptr.bcinttoptr.bcshort.bctrunc.bcissue_4.bcconflicting_global.bcissue_123_uint128_t.bcfizzbuzz_stateful.bcissue_94_strncmp.bczext.bcbyval_struct.bcnested_while.bcfunc_cond_two_arg.bcassert.bcswitch.bcbranch.bctemplate_parameter_pack.bcbyval_tail_nogep.llbyval_tail_gep.ll |
Should be passing most of checks, i think a few need some more work |
I think the AWS-related secrets can be removed |
Ah yeah, wasn't sure if we still wanted to upload the test artifacts to s3 |
AWS related secrets are DO spaces credentials that we upload artifacts to through their S3 compatible API |
@@ -173,26 +139,3 @@ jobs: | |||
AWS_ACCESS_KEY_ID: ${{ secrets.DO_SPACES_KEY_ID }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these still needed?
No description provided.