Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate CI to Github Large Runner #309

Merged
merged 5 commits into from
Oct 24, 2022
Merged

Migrate CI to Github Large Runner #309

merged 5 commits into from
Oct 24, 2022

Conversation

Ninja3047
Copy link
Contributor

No description provided.

@github-actions
Copy link

See the diff generated by this PR for the tests here: https://github.com/lifting-bits/rellic/actions/runs/3313437158

fizzbuzz.bc

typedefs_of_typedefs.bc

switch_loop.bc

func_cond_zero_arg.bc

fcmp.bc

conflicting_names.bc

struct.bc

issue_183_literal_structs.bc

zeroinit.bc

issue_127_uint128_t_lit.bc

struct_swap.bc

global_using_function_decl.bc

init_list.bc

reg_test_structure_fields.bc

ret0.bc

goto_loop.bc

bool.bc

bitops.bc

cast.bc

nullptr.bc

nested_struct.bc

array_swap.bc

binops.bc

bitmask.bc

loop.bc

float.bc

vectors.bc

funcptr.bc

inttoptr.bc

short.bc

trunc.bc

issue_4.bc

conflicting_global.bc

issue_123_uint128_t.bc

fizzbuzz_stateful.bc

issue_94_strncmp.bc

zext.bc

byval_struct.bc

nested_while.bc

--- /dev/fd/63	2022-10-24 14:19:07.518746030 +0000
+++ /dev/fd/62	2022-10-24 14:19:07.522746094 +0000
@@ -18,14 +18,14 @@
                 printf("loop1 x: %d\n", var1);
             }
     }
-    if ((int)var1 >= 20 || (int)var1 <= 10) {
+    if ((int)var1 <= 10 || (int)var1 >= 20) {
         while ((int)var1 < 20)
             {
                 var1 = var1 + 1U;
                 printf("loop2 x: %d\n", var1);
             }
     }
-    if ((int)var1 >= 20 && ((int)var1 >= 20 || (int)var1 <= 10)) {
+    if ((int)var1 >= 20 && ((int)var1 <= 10 || (int)var1 >= 20)) {
         return var0;
     }
 }

func_cond_two_arg.bc

assert.bc

switch.bc

branch.bc

template_parameter_pack.bc

byval_tail_nogep.ll

byval_tail_gep.ll

@github-actions
Copy link

See the diff generated by this PR for the tests here: https://github.com/lifting-bits/rellic/actions/runs/3314458380

fizzbuzz.bc

--- /dev/fd/63	2022-10-24 16:32:56.002768545 +0000
+++ /dev/fd/62	2022-10-24 16:32:56.002768545 +0000
@@ -11,7 +11,7 @@
     var1 = 0U;
     while ((int)var1 < 30)
         {
-            if ((int)var1 % 3 != 0U || !((int)var1 % 3 != 0U || (int)var1 % 5 == 0U)) {
+            if (!((int)var1 % 5 == 0U || (int)var1 % 3 != 0U) || (int)var1 % 3 != 0U) {
                 if ((int)var1 % 3 != 0U) {
                     if ((int)var1 % 5 != 0U) {
                         printf("%d\n", var1);

typedefs_of_typedefs.bc

switch_loop.bc

func_cond_zero_arg.bc

fcmp.bc

conflicting_names.bc

struct.bc

issue_183_literal_structs.bc

zeroinit.bc

issue_127_uint128_t_lit.bc

struct_swap.bc

global_using_function_decl.bc

init_list.bc

reg_test_structure_fields.bc

ret0.bc

goto_loop.bc

bool.bc

bitops.bc

cast.bc

nullptr.bc

nested_struct.bc

array_swap.bc

binops.bc

bitmask.bc

loop.bc

float.bc

vectors.bc

funcptr.bc

inttoptr.bc

short.bc

trunc.bc

issue_4.bc

conflicting_global.bc

issue_123_uint128_t.bc

fizzbuzz_stateful.bc

issue_94_strncmp.bc

zext.bc

byval_struct.bc

nested_while.bc

func_cond_two_arg.bc

assert.bc

switch.bc

branch.bc

template_parameter_pack.bc

byval_tail_nogep.ll

byval_tail_gep.ll

@github-actions
Copy link

See the diff generated by this PR for the tests here: https://github.com/lifting-bits/rellic/actions/runs/3314492638

fizzbuzz.bc

typedefs_of_typedefs.bc

switch_loop.bc

func_cond_zero_arg.bc

fcmp.bc

conflicting_names.bc

struct.bc

issue_183_literal_structs.bc

zeroinit.bc

issue_127_uint128_t_lit.bc

struct_swap.bc

global_using_function_decl.bc

init_list.bc

reg_test_structure_fields.bc

ret0.bc

goto_loop.bc

bool.bc

bitops.bc

cast.bc

nullptr.bc

nested_struct.bc

array_swap.bc

binops.bc

bitmask.bc

loop.bc

float.bc

vectors.bc

funcptr.bc

inttoptr.bc

short.bc

trunc.bc

issue_4.bc

conflicting_global.bc

issue_123_uint128_t.bc

fizzbuzz_stateful.bc

issue_94_strncmp.bc

zext.bc

byval_struct.bc

nested_while.bc

--- /dev/fd/63	2022-10-24 16:37:53.600835764 +0000
+++ /dev/fd/62	2022-10-24 16:37:53.600835764 +0000
@@ -18,14 +18,14 @@
                 printf("loop1 x: %d\n", var1);
             }
     }
-    if ((int)var1 >= 20 || (int)var1 <= 10) {
+    if ((int)var1 <= 10 || (int)var1 >= 20) {
         while ((int)var1 < 20)
             {
                 var1 = var1 + 1U;
                 printf("loop2 x: %d\n", var1);
             }
     }
-    if ((int)var1 >= 20 && ((int)var1 >= 20 || (int)var1 <= 10)) {
+    if ((int)var1 >= 20 && ((int)var1 <= 10 || (int)var1 >= 20)) {
         return var0;
     }
 }

func_cond_two_arg.bc

assert.bc

switch.bc

branch.bc

template_parameter_pack.bc

byval_tail_nogep.ll

byval_tail_gep.ll

@github-actions
Copy link

See the diff generated by this PR for the tests here: https://github.com/lifting-bits/rellic/actions/runs/3314555205

fizzbuzz.bc

typedefs_of_typedefs.bc

switch_loop.bc

func_cond_zero_arg.bc

fcmp.bc

conflicting_names.bc

struct.bc

issue_183_literal_structs.bc

zeroinit.bc

issue_127_uint128_t_lit.bc

struct_swap.bc

global_using_function_decl.bc

init_list.bc

reg_test_structure_fields.bc

ret0.bc

goto_loop.bc

bool.bc

bitops.bc

cast.bc

nullptr.bc

nested_struct.bc

array_swap.bc

binops.bc

bitmask.bc

loop.bc

float.bc

vectors.bc

funcptr.bc

inttoptr.bc

short.bc

trunc.bc

issue_4.bc

conflicting_global.bc

issue_123_uint128_t.bc

fizzbuzz_stateful.bc

issue_94_strncmp.bc

zext.bc

byval_struct.bc

nested_while.bc

func_cond_two_arg.bc

assert.bc

switch.bc

branch.bc

template_parameter_pack.bc

byval_tail_nogep.ll

byval_tail_gep.ll

@Ninja3047
Copy link
Contributor Author

Should be passing most of checks, i think a few need some more work

@Ninja3047 Ninja3047 requested a review from frabert October 24, 2022 17:03
@Ninja3047 Ninja3047 marked this pull request as ready for review October 24, 2022 17:03
@frabert
Copy link
Collaborator

frabert commented Oct 24, 2022

I think the AWS-related secrets can be removed

@Ninja3047
Copy link
Contributor Author

Ah yeah, wasn't sure if we still wanted to upload the test artifacts to s3
CC @artemdinaburg

@Ninja3047
Copy link
Contributor Author

AWS related secrets are DO spaces credentials that we upload artifacts to through their S3 compatible API

@@ -173,26 +139,3 @@ jobs:
AWS_ACCESS_KEY_ID: ${{ secrets.DO_SPACES_KEY_ID }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these still needed?

@frabert frabert merged commit 59b4751 into master Oct 24, 2022
@frabert frabert deleted the will/migrate-to-gha branch October 24, 2022 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants