Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to LLVM15 #308

Merged
merged 11 commits into from
Dec 22, 2022
Merged

Migrate to LLVM15 #308

merged 11 commits into from
Dec 22, 2022

Conversation

frabert
Copy link
Collaborator

@frabert frabert commented Oct 19, 2022

No description provided.

@Ninja3047
Copy link
Contributor

diff is failing to build due to llvm version mismatch, should get resolved after this gets merged

@frabert frabert requested a review from surovic December 21, 2022 16:14
Copy link
Contributor

@surovic surovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to be sure, the changes in various printers are straight copy-pastes from clang, right? Otherwise LGTM.

tools/xref/StmtPrinter.cpp Show resolved Hide resolved
tools/xref/StmtPrinter.cpp Show resolved Hide resolved
@frabert
Copy link
Collaborator Author

frabert commented Dec 22, 2022

All copy-pastes. I want to get rid of the custom printer when we update to LLVM16, but that might require using PASTA, which requires a patched Clang

@frabert frabert merged commit 87c50e8 into master Dec 22, 2022
@frabert frabert deleted the frabert/llvm-15 branch December 22, 2022 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants