Adds lift-json-scalaz7 (Scalaz 7 support). #1424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
March 20, 2013 12:43
* All tests pass, but only compiling for Scala 2.10.0 at the moment. * May need a lift-json-scalaz7 subproject to provide both Scalaz 6 and Scalaz 7 support.
* Adds a new submodule for lift-json-scalaz7. * Maintains lift-json-scalaz for Scalaz 6 support. * Updated README to correspond to Scalaz 7.
This reverts commit 765ae74.
| ---------- | ||
|
|
||
| Applicative style parsing works nicely with validation and data conversion. It is easy to compose | ||
| validations using a for comprehension. |
There was a problem hiding this comment.
Note, I removed the Kleisli composition example because Validation is not a monad in Scalaz 7 (see the Scalaz 7 thread). Using a for comprehension provides the same functionality albeit with a little more typing.
dpp
added a commit
that referenced
this pull request
Mar 22, 2013
Adds lift-json-scalaz7 (Scalaz 7 support). Based on Joni's mailing list thumbs up, I'm applying the patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds lift-json-scalaz7 (Scalaz 7 support).
Discussion on Lift mailing list.