Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency eslint-config-prettier to v6 #147

Merged
merged 1 commit into from
Jun 25, 2019

Conversation

renovate[bot]
Copy link

@renovate renovate bot commented Jun 25, 2019

This PR contains the following updates:

Package Type Update Change
eslint-config-prettier dependencies major ^5.0.0 -> ^6.0.0

Release Notes

prettier/eslint-config-prettier

v6.0.0

Compare Source

  • Changed: The CLI helper tool now considers [no-confusing-arrow] to conflict
    if you use the default value of its allowParens option. The default was
    changed to true in ESLint 6, which conflicts with Prettier.

    If the CLI helper tool gives you errors about this after upgrading, the
    solution is to change this:

    {
      "rules": {
        "no-confusing-arrow": ["error"]
      }
    }

    Into this:

    {
      "rules": {
        "no-confusing-arrow": ["error", { "allowParens": false }]
      }
    }

    The latter works in both ESLint 6 as well as in ESLint 5 and older.

  • Improved: eslint --print-config usage instructions. The CLI tool help
    text as well as the documentation has been updated to suggest commands that
    work in ESLint 6.0 as well as in ESLint 5 and older. (Instead of eslint --print-config ., use eslint --print-config path/to/main.js.)

v5.1.0

Compare Source

  • Added: [react/jsx-curly-newline]. Thanks to Masafumi Koba (@​ybiquitous)!

Renovate configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "rebase!".

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot. View repository job log here.

@codecov
Copy link

codecov bot commented Jun 25, 2019

Codecov Report

Merging #147 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           develop   #147   +/-   ##
======================================
  Coverage      100%   100%           
======================================
  Files            1      1           
  Lines            1      1           
======================================
  Hits             1      1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42ffcea...0a868ee. Read the comment docs.

@eaviles eaviles merged commit 96da102 into develop Jun 25, 2019
@renovate renovate bot deleted the feature/renovate-eslint-config-prettier-6.x branch June 25, 2019 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants