LPD-55969 Fix calendar accessibility non-confomity #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…without defining a role for itself
…tains the name of the month
|
From my analysis, it would be much more work to create a new paragraph tag within the div, I would need to modify the functions responsible for changes to the months. I would like to know if we can use the paragraph role in the div itself. |
Yeah, |
ethib137
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Ticket
To test this changes at runtime in liferay portal, please see: How to Use Chrome DevTools Override Content to Test Changes in YUI3 on Liferay
Result after changes:
simplescreenrecorder-2024-10-02_14.39.20.mp4