Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make script-src: 'unsafe-eval' unnecessary in CSP #33

Merged
merged 1 commit into from
Jul 25, 2023

Conversation

izaera
Copy link
Member

@izaera izaera commented Jul 24, 2023

This is part of https://liferay.atlassian.net/browse/LPS-178066 and allows YUI to run in servers using a CSP that doesn't include 'unsafe-eval'.

@bryceosterhaus
Copy link
Member

the original function seems like a little black magic to me, so your changes seem fine 🤷

@izaera
Copy link
Member Author

izaera commented Jul 25, 2023

the original function seems like a little black magic to me, so your changes seem fine shrug

Apparently it was a typical idiom used by transpilers, bundlers, etc... -> https://stackoverflow.com/questions/29706284/whats-the-purpose-of-new-functionreturn-this-in-immediately-invoked-fun

@dsanz dsanz merged commit cef17c9 into liferay:master Jul 25, 2023
@dsanz
Copy link
Member

dsanz commented Jul 25, 2023

Merged! Thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants