Skip to content

docs(guidelines): update frequent reviewers list #419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wincent merged 1 commit into from
Feb 26, 2021
Merged

docs(guidelines): update frequent reviewers list #419

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion guidelines/dxp/code_review.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,9 @@ These are guidelines that the Frontend Infrastructure Team follows when developi

Note that if you create PRs with [the `gh` command-line tool](https://www.npmjs.com/package/gh) you obviously can't see or check a checkbox. In that case, you may wish to add the people who most frequently review your code as [collaborators to your repo](https://help.github.com/en/github/setting-up-and-managing-your-github-user-account/inviting-collaborators-to-a-personal-repository), as well as the team members who tend to be generally involved in code review:

- [brunobasto](https://github.com/brunobasto)
- [bryceosterhaus](https://github.com/bryceosterhaus)
- [jbalsas](https://github.com/jbalsas)
- [jonmak08](https://github.com/jonmak08)
- [markocikos](https://github.com/markocikos)
- [wincent](https://github.com/wincent)

Expand Down