chore(npm-scripts): update liferay-theme-tasks dependency to v10.2.0 #371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because it is causing CI to fail on `master`: https://github.com/liferay/liferay-frontend-projects/runs/1599790394 Note this is not a permanent fix: I'm including it just to show what Yarn is complaining about. We obviously don't want this package in the lockfile, and we don't want `yarn why liferay-theme-tasks` reporting that we are using two versions of our own package in the monorepo: $ yarn why liferay-theme-tasks yarn why v1.22.5 [1/4] 🤔 Why do we have the module "liferay-theme-tasks"...? [2/4] 🚚 Initialising dependency graph... warning Missing version in workspace at "/Users/greghurrell/code/liferay-frontend-projects/projects/js-themes-toolkit", ignoring. [3/4] 🔍 Finding dependency... [4/4] 🚡 Calculating file sizes... => Found "[email protected]" info Has been hoisted to "liferay-theme-tasks" info Reasons this module exists - "workspace-aggregator-7d980a7c-b46c-48a8-bf4c-7ec9dfab795d" depends on it - Specified in "dependencies" - Hoisted from "_project_#liferay-theme-tasks" - Hoisted from "_project_#generator-liferay-theme#liferay-theme-tasks" info Disk size without dependencies: "2.6MB" info Disk size with unique dependencies: "19.55MB" info Disk size with transitive dependencies: "75.89MB" info Number of shared dependencies: 313 => Found "@liferay/npm-scripts#[email protected]" info This module exists because "_project_#@liferay#npm-scripts" depends on it. info Disk size without dependencies: "1.64MB" info Disk size with unique dependencies: "15.36MB" info Disk size with transitive dependencies: "68.57MB" info Number of shared dependencies: 310 ✨ Done in 1.76s. So I'll follow up with the real fix for that in the next commit.
Release notes for that:
https://github.com/liferay/liferay-frontend-projects/releases/tag/liferay-theme-tasks%2Fv10.2.0
Main point of interest is that it adds a JS minification step to the
theme build:
#365
Contributor
Author
|
All PRs are going to be red until this is merged (example) so I'm just going to merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the commit messages say...
fix(monorepo): cure lockfile staleness
Because it is causing CI to fail on
master.Note this is not a permanent fix: I'm including it just to show what Yarn is complaining about. We obviously don't want this package in the lockfile, and we don't want
yarn why liferay-theme-tasksreporting that we are using two versions of our own package in the monorepo:So I'll follow up with the real fix for that in the next commit.
chore(npm-scripts): update liferay-theme-tasks dependency to v10.2.0
Release notes for that.
Main point of interest is that it adds a JS minification step to the theme build.