feat: add liferay-portal/no-react-dom-render rule

[wincent]

Just for fun, I made this one pretty comprehensive (but not exhaustive) in terms of finding bindings to the "react-dom" render() function. I took the simple approach of remembering imports as I see them, and checking CallExpression nodes along the way to see if they correspond to an import. This is in contrast to the alternative approach which would be to scan the entire input accumulating imports and then checking CallExpressions at the very end.

Three reasons for this:

• It's simpler.
• import statements usually go at the top of the file, so we will probably always see them first.
• I suspect, but am not sure, that import bindings have const semantics, and so are affected by the temporal dead zone, which makes it even less likely that they'd be used before we've seen them (you could still use them inside a lazily-executed function, but I think the odds of that are vanishingly small).

Possible add-on to consider:

• Do want to allow ReactDOM.render inside test/**/*.js directories?

[wincent]

The irony.

[wincent]

Going to merge this — tested it in liferay-portal and all is good — and if we decide we want to loop back and add an exception that allows the use of ReactDOM.render in tests, that will be easy enough:

diff --git a/portal.js b/portal.js
index b18ebf5..b097269 100644
--- a/portal.js
+++ b/portal.js
@@ -17,6 +17,14 @@ const config = {
 			jsx: true,
 		},
 	},
+	overrides: [
+		{
+			files: ['**/test/**/*.js'],
+			rules: {
+				'liferay-portal/no-react-dom-render': 'off',
+			},
+		},
+	],
 	plugins: [local('liferay-portal')],
 	rules: {
 		'liferay-portal/no-explicit-extend': 'error',

Although in tests, we might actually want to recommend the use of the render function from @testing-library/react instead.