This repository has been archived by the owner on Sep 30, 2020. It is now read-only.
feat: add "react" variant #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This extends the base plugin, adding "eslint-plugin-react" on top of
that.
To use, instead of extending the base:
extends: ['liferay'],
extend the variant:
extends: ['liferay/react'],
You don't need to extend both, because "liferay/react" already extends "liferay".
|
@wincent no problem, thanks for that. |
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@matuzalemsteles: I made this because we are rolling out ESLint in liferay-portal, at which point I realized that you had already made a version of this in #37 and I forgot all about it.
So, I pulled down your commits and cherry-picked them on top (the README updates, and the hooks plugin, which I'd forgotten about). The only real difference between yours and mine is that I have "liferay/react" extending "liferay" by default. Also updating the dependencies while I'm at it.
Closes: #37