chore: eslint-plugin migration

[kresimir-coko]

Part of liferay/liferay-frontend-projects#677.

I've disabled rules that were spitting errors so that yarn lint returns the same warnings as it does on master.

This is my first time contributing here, so if I overlooked something, let me know

[diegonvs]

When enabling:

✖ 877 problems (231 errors, 646 warnings)
  20 errors and 0 warnings potentially fixable with the `--fix` option.

😢

Also, It emits some warnings like:

for sorting keys but it's just a warning

ohh, but I saw this commit here and since this project is under maintenance mode I think it's okay to not working in fixing those warns.

So, I think this PR is okay to be merged since it disables the failing rules.

Hey @markocikos, @carloslancha can I hit merge?

[diegonvs]

Hey @kresimir-coko, could you run npx yarn-deduplicate and squash with the changes in the lockfile? When running in my machine it detected some possible optimizations :)

[kresimir-coko]

Hey @diegonvs I've ran the command and squashed all commits before force-pushing. So give it another try and lemme know if I need to change anything else

[markocikos]

@kresimir-coko I tried it out, looks good! yarn lint:

But, I needed to install these packages, that ended up in root package.json. If this the result of something missing on my side, or do we need to update these dependencies?

"devDependencies": {
	...
	"eslint-plugin-notice": "^0.9.10",
	"eslint-plugin-react": "^7.26.1",
	"eslint-plugin-react-hooks": "^4.2.0",
	"eslint-plugin-sort-destructure-keys": "^1.3.5",
	...
}

[kresimir-coko]

@markocikos If this the result of something missing on my side, or do we need to update these dependencies?

I'll investigate a bit later and report back with my findings

[kresimir-coko]

@markocikos so you pulled my changes and just ran yarn lint which added those packages to package.json? I can't seem to replicate that.

[markocikos]

@kresimir-coko It looks like this was fake news, something was messed up with my repo. After cleaning up node_modules with git clean -dfx, I cannot reproduce #1505 (review).

I did need to do yarn install first, because yarn lint reports that eslint: not found otherwise. This updates yarn lock file. Are you doing something different to enable yarn lint?

[kresimir-coko]

I don't get the issue with eslint missing, according to package.json it should be present. Here's the steps I took:

1. git clean -dfx
2. yarn install - creates a yarn.lock
3. npx yarn-deduplicate
4. yarn lint - works without issue

Note: I force-pushed once again because either my initial npx yarn-deduplicate didn't do anything (even though it did modify the yarn.lock file, or I missed something.

[markocikos]

Works flawlessly now! 👍