fix: Prevent activeCommand in button-paragraph-align.jsx to be undefined (#1500) #1501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegonvs
approved these changes
Sep 14, 2021
There was a problem hiding this comment.
It partially fixes the error but We introduce another issue here:
justifyleft is being set as a default. So, when selecting a "justified center" text, it will show the selection as justify left but it will not crash as https://issues.liferay.com/browse/LPS-138431 describes :)
Hi @diegonvs, Could we try to check on CKEditor side if we can fix this? I opened https://issues.liferay.com/browse/LPS-139384 for this. Regards. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1500
If you add 'paragraphAlign' button to Alloy Editor Configurator and you add a paragraph text with an image inside, it will fail to open the menu. Check https://issues.liferay.com/browse/LPS-138431