Skip to content

fix: Add feedback for semantic-release #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
atolivero merged 1 commit into from
Apr 6, 2022
Merged

fix: Add feedback for semantic-release #212

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/lifeomic-probot.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
enforceSemanticCommits: true
3 changes: 2 additions & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
environment: npm
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
NPM_TOKEN: ${{secrets.LIFEOMIC_NPM_TOKEN}}
NPM_TOKEN: ${{ secrets.LIFEOMIC_NPM_TOKEN }}
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v1
Expand All @@ -20,6 +20,7 @@ jobs:
registry-url: https://registry.npmjs.org
- name: Build and Test
run: |
echo "//registry.npmjs.org/:_authToken=${NPM_TOKEN}" > .npmrc
Copy link
Contributor Author

@atolivero atolivero Apr 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last build failed - based on the docs, I thought semantic-release would pick up the token from the environment variable, but I'm adding this to see if it picks it up from there

Copy link
Contributor Author

@atolivero atolivero Apr 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And I did confirm that this repo is configured for the npm environment in repo-standard, so this token should be available

Copy link

@swain swain Apr 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change. If the setup-node action sets an .npmrc file (seems possible), then it will override our token.

I actually tried to fix the semantic-release docs around this a while back 😂, because they were wrong. Even with my fix, they're still not great :/

semantic-release/npm#413

yarn install
yarn test
yarn build
Expand Down
10 changes: 5 additions & 5 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@lifeomic/cli",
"version": "13.6.0",
"version": "0.0.0",
"description": "CLI for interacting with the LifeOmic PHC API.",
"main": "lo.js",
"author": "LifeOmic <development@lifeomic.com>",
Expand All @@ -17,8 +17,7 @@
"lint": "eslint .",
"pretest": "yarn lint",
"test": "ava --serial --verbose test/unit",
"build": "./build.sh",
"semantic-release": "semantic-release"
"build": "./build.sh"
},
"dependencies": {
"axios": "^0.21.1",
Expand Down Expand Up @@ -54,12 +53,13 @@
"@lifeomic/eslint-plugin-node": "^1.3.0",
"ava": "^0.25.0",
"axios-mock-adapter": "^1.19.0",
"conventional-changelog-conventionalcommits": "^4.6.3",
"eslint": "^4.19.1",
"memory-streams": "^0.1.3",
"pkg": "^4.4.3",
"proxyquire": "^2.1.0",
"sinon": "^4.5.0",
"semantic-release": "^19.0.2"
"semantic-release": "^19.0.2",
"sinon": "^4.5.0"
},
"eslintConfig": {
"extends": "plugin:@lifeomic/node/recommended"
Expand Down
1 change: 1 addition & 0 deletions release.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
module.exports = {
branches: ['master'],
plugins: [
['@semantic-release/commit-analyzer', { preset: 'conventionalcommits' }],
'@semantic-release/npm',
[
'@semantic-release/github',
Expand Down
9 changes: 9 additions & 0 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2031,6 +2031,15 @@ conventional-changelog-angular@^5.0.0:
compare-func "^2.0.0"
q "^1.5.1"

conventional-changelog-conventionalcommits@^4.6.3:
version "4.6.3"
resolved "https://registry.yarnpkg.com/conventional-changelog-conventionalcommits/-/conventional-changelog-conventionalcommits-4.6.3.tgz#0765490f56424b46f6cb4db9135902d6e5a36dc2"
integrity sha512-LTTQV4fwOM4oLPad317V/QNQ1FY4Hju5qeBIM1uTHbrnCE+Eg4CdRZ3gO2pUeR+tzWdp80M2j3qFFEDWVqOV4g==
dependencies:
compare-func "^2.0.0"
lodash "^4.17.15"
q "^1.5.1"

conventional-changelog-writer@^5.0.0:
version "5.0.1"
resolved "https://registry.yarnpkg.com/conventional-changelog-writer/-/conventional-changelog-writer-5.0.1.tgz#e0757072f045fe03d91da6343c843029e702f359"
Expand Down