Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use content-tag in glint env #52

Merged
merged 1 commit into from
Jan 23, 2024
Merged

use content-tag in glint env #52

merged 1 commit into from
Jan 23, 2024

Conversation

lifeart
Copy link
Owner

@lifeart lifeart commented Jan 23, 2024

thanks to typed-ember/glint#655 @NullVoxPopuli for simple migration!

Resolves: #49

Copy link

netlify bot commented Jan 23, 2024

Deploy Preview for g-next ready!

Name Link
🔨 Latest commit f630e16
🔍 Latest deploy log https://app.netlify.com/sites/g-next/deploys/65afb5691ce3860008e6cb85
😎 Deploy Preview https://deploy-preview-52--g-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@lifeart lifeart changed the title use content-tag use content-tag in glint env Jan 23, 2024
Copy link

Code Coverage Report

Coverage after merging content-tag-for-glint into master

74.33%
Coverage Report
FileLines (%)Funcs (%)Uncovered Lines
.../pages/page-one
   Smile.ts79.596, 7, 8, 9, ...
.../pages/page-two
   Clock.ts94.2983.3318, 27
tests
   utils.ts95.6531, 75, 76, 77, ...
utils
   benchmark.ts69.4419, 20, 21, 22, ...
   compat.ts96.2328, 29, 30, 38, ...
   component.ts96.6570, 8, 9, 91, ...
   dom-api.ts15, 21
   dom.ts96.8891.89598, 605, 624, 75, ...
   ember-inspector.ts14.70096, 97, 98, 99, ...
   if.ts57.2766.6796, 97, 98, 99, ...
   list.ts93.778576, 80, 81, 82, ...
   reactive.ts99.2460, 61, 79, 80, ...
   rehydration-dom-api.ts50.7996, 97, 98, 99, ...
   rehydration.ts135, 144
   runtime.ts95.7411, 12, 13
   shared.ts7492, 93, 94, 95, ...
   vm.ts24, 4, 56
utils/helpers
   if.ts66.672, 3, 4
utils/inspector
   index.ts33.33096, 97, 98, 99, ...

@lifeart lifeart marked this pull request as ready for review January 23, 2024 12:49
@lifeart lifeart merged commit f7f1dc5 into master Jan 23, 2024
8 checks passed
@lifeart lifeart deleted the content-tag-for-glint branch January 23, 2024 12:49
Copy link

duration phase no difference [-9ms to 280ms]
renderEnd phase no difference [-2ms to 1ms]
render1000Items1End phase no difference [-10ms to 12ms]
clearItems1End phase no difference [-2ms to 5ms]
render1000Items2End phase no difference [0ms to 17ms]
clearItems2End phase no difference [0ms to 0ms]
render5000Items1End phase estimated regression +34ms [3ms to 66ms] OR +0.89% [0.07% to 1.74%]
clearManyItems1End phase no difference [-2ms to 5ms]
render5000Items2End phase estimated regression +33ms [0ms to 53ms] OR +0.94% [0.01% to 1.52%]
clearManyItems2End phase no difference [0ms to 1ms]
render1000Items3End phase no difference [0ms to 17ms]
append1000Items1End phase no difference [-17ms to 17ms]
append1000Items2End phase estimated regression +34ms [17ms to 66ms] OR +4.15% [2.04% to 8.12%]
updateEvery10thItem1End phase no difference [-18ms to 16ms]
updateEvery10thItem2End phase no difference [-4ms to 11ms]
selectFirstRow1End phase no difference [0ms to 0ms]
selectSecondRow1End phase no difference [0ms to 0ms]
removeFirstRow1End phase no difference [0ms to 1ms]
removeSecondRow1End phase no difference [-3ms to 9ms]
swapRows1End phase no difference [-2ms to 5ms]
swapRows2End phase no difference [-1ms to 1ms]
clearItems4End phase no difference [-1ms to 4ms]
paint phase no difference [0ms to 0ms]

[13:39:30] Generating Benchmark Reports [started]
[13:39:35] Generating Benchmark Reports [completed]

Benchmark Reports    

JSON: /home/runner/work/glimmer-next/glimmer-next/tracerbench-results/compare.json

PDF: /home/runner/work/glimmer-next/glimmer-next/tracerbench-results/artifact-1.pdf

HTML: /home/runner/work/glimmer-next/glimmer-next/tracerbench-results/artifact-1.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom Glint environment
1 participant