Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer ed25519 over rsa signatures #475

Open
wants to merge 2 commits into
base: 2.x
Choose a base branch
from

Conversation

dodmi
Copy link
Contributor

@dodmi dodmi commented Dec 13, 2024

This changes the signature sort behavior, such that an ed25519 signature will be preferred over a corresponding rsa signature.

For any ed25519 signature, there's a corresponding rsa signature for backward compatibility;
in the case that weak rsa keys are handled as warning and the ed25519 signature also produces a warning, it might happen, that the rsa signature is ranked first and therefore a weak key warning appeared in spite of a valid ed25519 signature is in place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant