2.x: Backport feature detailed results 5 to 2x #449
Conversation
modified: data/favicon.json new file: data/favicon/congenio.de.png modified: data/signersDefault.json modified: modules/dkimVerifier.jsm.js modified: modules/helper.jsm.js
dodmi
force-pushed
the
backport-feature-detailed-results-5-2x
branch
from
1620476 to
f77bd62
Compare
|
Thanks for back porting this work in progress. I will try to find time this weekend to continue the work on this for 5.x, and also more closely look at your back port. |
|
Feel free to use parts of my code or let me know if I should change/improve something. I'm pretty happy, but I have no solution for cut tooltips. But this isn't a problem for one or two signatures, which is the usual amount, as I can easily see now :) |
dodmi
changed the title
|
I don't plan to change anything at the moment unless I broke something while merging the other commits. So please merge the PR, this will make further changes easier. |
I'm creating a pull request for my backport of displaying detailed results. So you can see the code matching the screenshots.
I'm pretty happy with the output, now. But I'm unhappy, how I solved the GUI part in chrome/content/dkim.js.
I don't really understand your code in bindings.xml (or custom XUL elements in general). So my implementation is pretty ugly and probably needs some improvement.
The clean way would probably be extending bindings.xml and not manipulating DOM objects directly...