Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Lido.handleOracleReport reorder burn and fee distribution #690

Merged
merged 1 commit into from
Mar 16, 2023
Merged

Fix: Lido.handleOracleReport reorder burn and fee distribution #690

merged 1 commit into from
Mar 16, 2023

Conversation

TheDZhon
Copy link
Contributor

The idea is to harden the accounting processing
Shares should be burnt BEFORE the fee distribution.

@TheDZhon
fix: Lido.handleOracleReport swap steps 6 and 7
ac8b87d 
The idea is to harden the accounting processing
Shares should be burnt BEFORE the fee distribution
@TheDZhon TheDZhon changed the title Fix: lido reorder burn Fix: Lido.handleOracleReport reorder burn and fee distribution Mar 16, 2023
folkyatina
folkyatina approved these changes Mar 16, 2023
View reviewed changes
Copy link
Member

@folkyatina folkyatina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@TheDZhon TheDZhon merged commit e6e0edc into fix/shapella-upgrade-beta3-to-rc Mar 16, 2023
@TheDZhon TheDZhon deleted the fix/lido-reorder-burn branch March 16, 2023 16:12
@TheDZhon TheDZhon mentioned this pull request Mar 16, 2023
Merged
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@folkyatina folkyatina folkyatina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TheDZhon @folkyatina