Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP ValidatorsExitBus Oracle tests #638

Merged
merged 21 commits into from
Feb 20, 2023
Merged

WIP ValidatorsExitBus Oracle tests #638

merged 21 commits into from
Feb 20, 2023
+451 −27

Conversation

DiRaiks
Copy link
Contributor

@DiRaiks DiRaiks commented Feb 20, 2023 •
edited by Jeday
Loading

  • clean up/add helpers/etc at existing tests
  • deploy tests
    • initialise
      • paused at initilazed
    • interacting contracts are set
  • pause/resume(can be part of other tests)
    • report submitting is not available at pause
  • _handleConsensusReport callback(invoked at the end of baseOracle.submitConsensusReport by HashConsensus contract)
    • happy path
    • emits warning on incomplete processing
    • not accessible with current report types
  • submitReportData
    • surface tests that baseOracle internal checks are invoked
    • security(can be part of other/older tests)
      • custom AC (_checkMsgSenderIsAllowedToSubmitData)
      • hash match with report is enforced
      • data safety is enforced
    • _handleConsensusReportData
      • enforces data format
      • enforces length
      • enforces increasing validator indices within one node operator
      • sanity check invoke
      • _processExitRequestsList
        • assembly
      • processing state is updated
  • At Init/After/Between report view function reflect correct oracle state
    • getTotalRequestsProcessed
    • getLastRequestedValidatorIndices
    • getProcessingState

@DiRaiks DiRaiks marked this pull request as draft February 20, 2023 09:22
@TheDZhon TheDZhon mentioned this pull request Feb 20, 2023
Merged
26 tasks
Jeday and others added 14 commits February 20, 2023 17:42
@Jeday
feat: getTotalRequestsProcessed tests
6c129c6
@manneredboor
test: ValidatorsExitBusOracle._handleConsensusReportData validates re…
bd17933 
…questsCount field with given data
@manneredboor
test: ValidatorsExitBusOracle._handleConsensusReportData updates proc…
2e9d69c 
…essing state
@Jeday
feat: getProcessingState tests
8a42e43
@Jeday
Merge branch 'feature/shapella-upgrade-tests-validators-exit-bus-orac…
19cf415 
…le' of github.com:lidofinance/lido-dao into feature/shapella-upgrade-tests-validators-exit-bus-oracle
@manneredboor
test: ValidatorsExitBusOracle._handleConsensusReportData updates tota…
7690377 
…l requests processed count
@manneredboor
test: ValidatorsExitBusOracle._handleConsensusReportData checks that …
eb19d96 
…moduleId is not equals zero
@manneredboor
test: ValidatorsExitBusOracle._handleConsensusReportData emits Valida…
90b526f 
…torExitRequest events
@manneredboor
test: remove unrelevant testcase
41d2413
@Jeday
feat: pause tests and clean up
dc90118
@Jeday
chore: abi
b90b6f9
@Jeday
Merge branch 'feature/shapella-upgrade-tests-validators-exit-bus-orac…
2d67863 
…le' of github.com:lidofinance/lido-dao into feature/shapella-upgrade-tests-validators-exit-bus-oracle
@Jeday
Merge branch 'feature/shapella-upgrade-followups' of github.com:lidof…
044951f 
…inance/lido-dao into feature/shapella-upgrade-tests-validators-exit-bus-oracle
@Jeday
fix: snapshot variable not defined
4472dfb
@TheDZhon TheDZhon marked this pull request as ready for review February 20, 2023 13:16
TheDZhon
TheDZhon approved these changes Feb 20, 2023
View reviewed changes
Copy link
Contributor

@TheDZhon TheDZhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TheDZhon TheDZhon merged commit 694c669 into feature/shapella-upgrade-followups Feb 20, 2023
@TheDZhon TheDZhon deleted the feature/shapella-upgrade-tests-validators-exit-bus-oracle branch February 20, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheDZhon TheDZhon TheDZhon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DiRaiks @TheDZhon @manneredboor @Jeday