WIP ValidatorsExitBus Oracle tests

contracts/0.8.9/test_helpers/oracle/ValidatorsExitBusTimeTravellable.sol

@@ -30,4 +30,8 @@ contract ValidatorsExitBusTimeTravellable is ValidatorsExitBusOracle, ITimeProvi
         address consensus = CONSENSUS_CONTRACT_POSITION.getStorageAddress();
         return ITimeProvider(consensus).getTime();
     }
+
+    function getDataProcessingState() external view returns (DataProcessingState memory) {
+        return _storageDataProcessingState().value;
+    }
 }

test/0.8.9/oracle/hash-consensus-access-control.test.js

@@ -11,6 +11,7 @@ const MockReportProcessor = artifacts.require('MockReportProcessor')
 contract('HashConsensus', ([admin, account1, account2, member1, member2]) => {
   let consensus = null
   let reportProcessor = null
+  let snapshot = null
   const manageMembersAndQuorumRoleKeccak156 = web3.utils.keccak256('MANAGE_MEMBERS_AND_QUORUM_ROLE')
   const disableConsensusRoleKeccak156 = web3.utils.keccak256('DISABLE_CONSENSUS_ROLE')
   const manageFrameConfigRoleKeccak156 = web3.utils.keccak256('MANAGE_FRAME_CONFIG_ROLE')

test/0.8.9/oracle/validators-exit-bus-oracle-access-control.test.js

@@ -12,9 +12,7 @@ const {
 const PUBKEYS = [
   '0xaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa',
   '0xbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb',
-  '0xcccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccc',
-  '0xdddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddd',
-  '0xeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee'
+  '0xcccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccc'
 ]
 
 contract('ValidatorsExitBusOracle', ([admin, member1, member2, member3, account1, stranger]) => {

test/0.8.9/oracle/validators-exit-bus-oracle-deploy.test.js

@@ -31,9 +31,6 @@ function getReportDataItems(r) {
 
 function calcReportDataHash(reportItems) {
   const data = web3.eth.abi.encodeParameters(['(uint256,uint256,uint256,uint256,bytes)'], [reportItems])
-  // const toS = x => Array.isArray(x) ? `[${x.map(toS)}]` : `${x}`
-  // console.log(toS(reportItems))
-  // console.log(data)
   return web3.utils.keccak256(data)
 }
 
@@ -84,7 +81,7 @@ module.exports = {
 async function deployOracleReportSanityCheckerForExitBus(lidoLocator, admin) {
   const maxValidatorExitRequestsPerReport = 2000
   const limitsList = [0, 0, 0, 0, maxValidatorExitRequestsPerReport, 0, 0, 0, 0]
-  const managersRoster = [[admin], [], [], [], [], [], [], [], [], []]
+  const managersRoster = [[admin], [admin], [admin], [admin], [admin], [admin], [admin], [admin], [admin], [admin]]
 
   const OracleReportSanityChecker = artifacts.require('OracleReportSanityChecker')
 
@@ -97,16 +94,19 @@ async function deployOracleReportSanityCheckerForExitBus(lidoLocator, admin) {
       from: admin
     }
   )
-  return oracleReportSanityChecker.address
+  return oracleReportSanityChecker
 }
 
-async function deployExitBusOracle(admin, {
-  dataSubmitter = null,
-  lastProcessingRefSlot = 0,
-  resumeAfterDeploy = false,
-  pauser = ZERO_ADDRESS,
-  resumer = ZERO_ADDRESS,
-} = {}) {
+async function deployExitBusOracle(
+  admin,
+  {
+    dataSubmitter = null,
+    lastProcessingRefSlot = 0,
+    resumeAfterDeploy = false,
+    pauser = ZERO_ADDRESS,
+    resumer = ZERO_ADDRESS
+  } = {}
+) {
   const locator = (await deployLocatorWithDummyAddressesImplementation(admin)).address
 
   const oracle = await ValidatorsExitBusOracle.new(SECONDS_PER_SLOT, GENESIS_TIME, locator, { from: admin })
@@ -119,7 +119,7 @@ async function deployExitBusOracle(admin, {
   const oracleReportSanityChecker = await deployOracleReportSanityCheckerForExitBus(locator, admin)
   await updateLocatorImplementation(locator, admin, {
     validatorsExitBusOracle: oracle.address,
-    oracleReportSanityChecker: oracleReportSanityChecker
+    oracleReportSanityChecker: oracleReportSanityChecker.address
   })
 
   const initTx = await oracle.initialize(
@@ -129,7 +129,7 @@ async function deployExitBusOracle(admin, {
     consensus.address,
     CONSENSUS_VERSION,
     lastProcessingRefSlot,
-    {from: admin}
+    { from: admin }
   )
 
   assert.emits(initTx, 'ContractVersionSet', { version: 1 })
@@ -162,8 +162,9 @@ async function deployExitBusOracle(admin, {
     await oracle.resume({ from: admin })
   }
 
-  return { consensus, oracle, locator, initTx }
+  return { consensus, oracle, oracleReportSanityChecker, locator, initTx }
 }
+
 contract('ValidatorsExitBusOracle', ([admin, member1]) => {
   let consensus
   let oracle
@@ -180,7 +181,6 @@ contract('ValidatorsExitBusOracle', ([admin, member1]) => {
       assert.equal(+(await oracle.getTime()), time1)
 
       await consensus.advanceTimeBy(SECONDS_PER_SLOT)
-
       const time2 = +(await consensus.getTime())
       assert.equal(time2, time1 + SECONDS_PER_SLOT)
       assert.equal(+(await oracle.getTime()), time2)
@@ -192,5 +192,13 @@ contract('ValidatorsExitBusOracle', ([admin, member1]) => {
       assert.equal(+(await oracle.SECONDS_PER_SLOT()), SECONDS_PER_SLOT)
       assert.equal(await oracle.isPaused(), true)
     })
+
+    it('pause/resume operations work', async () => {
+      assert.equal(await oracle.isPaused(), true)
+      await oracle.resume()
+      assert.equal(await oracle.isPaused(), false)
+      await oracle.pause(123)
+      assert.equal(await oracle.isPaused(), true)
+    })
   })
 })