Fix and multiple improvements to OracleReportSanityChecker #629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
arwer13
commented
Feb 17, 2023
arwer13
commented
- make checks for extraDataListItems and nodeOperatorsPerExtraDataItem depend on two separate limits
- add check for max (due packing) value of a limit in setters
- refactor order of the limits
- add 2 simple tests for the setters
- make checks for extraDataListItems and nodeOperatorsPerExtraDataItem depend on two separate limits - add check for max (due packing) value of a limit in setters - refactor order of the limits - add 2 simple tests for the setters
26 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.