More efficient accounting oracle

[skozin]

Avoids non-trivial processing of exited/stuck validators report data in the accounting oracle by using bytes packing in the Staking Router's methods that receive the data from the oracle.

Gets rid of the hardly-explainable and non-semantical extraDataMaxNodeOpsCountByModule report field. ResizableArray is not needed anymore.

Should be significantly more gas-efficient than the current impl.

[avsetsin]

_processExtraDataItem handles specific two item types, this may not be flexible enough. Not sure if solidity allows it, but something like this might be more flexible and improve the semantics:

if (itemType == EXTRA_DATA_TYPE_EXITED_VALIDATORS) {
    (uint256 moduleId, bytes calldata nodeOpIds, bytes calldata valsCounts) = _extractKeysCounts(data, iter);
    IStakingRouter(iter.stakingRouter)
        .reportStakingModuleExitedKeysCountByNodeOperator(moduleId, nodeOpIds, valsCounts);
} else if (itemType == EXTRA_DATA_TYPE_STUCK_VALIDATORS) {
    (uint256 moduleId, bytes calldata nodeOpIds, bytes calldata valsCounts) = _extractKeysCounts(data, iter);
    IStakingRouter(iter.stakingRouter)
        .reportStakingModuleStuckKeysCountByNodeOperator(moduleId, nodeOpIds, valsCounts);
} else {
    revert UnsupportedExtraDataType(index, itemType);
}

1. rename _processExtraDataItem into something more specific that performs the key extraction, like _extractKeysCounts
2. move Staking Router methods calls from _extractKeysCounts here

[skozin]

yeah, this structuring would be better, and Solidity allows this. I'll try finding time to improve as you suggested

[TheDZhon]

Thank you 🚀
Gonna be the most efficient way of passing data 💯