Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployment to Optimism Sepolia #19

Merged
merged 10 commits into from
Feb 22, 2024
Merged

Conversation

kovalgek
Copy link

@kovalgek kovalgek commented Feb 7, 2024

Deploy bridge executor for Optimism Sepolia testnet

@TheDZhon
Copy link

Seems there were no secrets for Arbitrum and Optimism to verify the bytecode.
Fixed this 👍

Copy link

@arwer13 arwer13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Could refactor a bit in some place to replace specific testnet name by just "testnet", but let's opt out of this for now.

Copy link

@TheDZhon TheDZhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Thank you for keeping the things up-to-date, I'd suggest a bit more polishing 🙏

helpers/gov-constants.ts Outdated Show resolved Hide resolved
helpers/gov-constants.ts Outdated Show resolved Hide resolved
helpers/gov-constants.ts Outdated Show resolved Hide resolved
helpers/gov-constants.ts Show resolved Hide resolved
Copy link

@TheDZhon TheDZhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for improvements 🙏

Yet i'd suggest giving it one more shot 🔫

hardhat.config.ts Outdated Show resolved Hide resolved
hardhat.config.ts Outdated Show resolved Hide resolved
hardhat.config.ts Outdated Show resolved Hide resolved
helpers/gov-constants.ts Outdated Show resolved Hide resolved
helpers/gov-constants.ts Outdated Show resolved Hide resolved
Copy link

@TheDZhon TheDZhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@kovalgek kovalgek merged commit 1222f1c into master Feb 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants