Fix: too high simulated share rate #730
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the simulated share rate to be either higher or lower within the defined bounds.
A brief explanation was added to the code (see the key extracts below).
Test cases to illustrate both possible scenarios are provided with the current PR.
Resolves the issue with the missed
AccountingOracle
reports on Görli. The weakness has been discovered internally and hasn't been reported by external teams yet.Previously existing test cases with submits between
ref_slot
and submit data block didn't trigger revert because of insufficient TVL change.