Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle oracle report edge tests #610

Merged
merged 1 commit into from
Feb 13, 2023
Merged

handle oracle report edge tests #610

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions contracts/0.8.9/test_helpers/FunderMock.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
// SPDX-FileCopyrightText: 2023 Lido <[email protected]>
//SPDX-License-Identifier: GPL-3.0

pragma solidity 0.8.9;

contract FunderMock {
function pay(address payable _target) external payable {
selfdestruct(_target);
}
}
256 changes: 234 additions & 22 deletions test/0.4.24/lido-handle-oracle-report.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,15 @@ const { EvmSnapshot } = require('../helpers/blockchain')
const { ZERO_ADDRESS } = require('../helpers/constants')
const { setupNodeOperatorsRegistry } = require('../helpers/staking-modules')

const ETHForwarderMock = artifacts.require('ETHForwarderMock')
const FunderMock = artifacts.require('FunderMock')
const RewardEmulatorMock = artifacts.require('RewardEmulatorMock')
const ONE_YEAR = 3600 * 24 * 365
const ONE_DAY = 3600 * 24

contract('Lido: handleOracleReport', ([appManager, , , , , , , stranger, anotherStranger, depositor, operator]) => {
let deployed, snapshot, lido, treasury, voting, oracle
let curatedModule, oracleReportSanityChecker
let curatedModule, oracleReportSanityChecker, elRewardsVault
let withdrawalRewarderMock, withdrawalVault, elRewarderMock
let strangerBalanceBefore,
anotherStrangerBalanceBefore,
totalPooledEtherBefore,
Expand All @@ -38,7 +40,10 @@ contract('Lido: handleOracleReport', ([appManager, , , , , , , stranger, another
}
})

await ETHForwarderMock.new(deployed.oracle.address, { from: appManager, value: ETH(1) })
const funder = await FunderMock.new()
await funder.pay(deployed.oracle.address, { value: ETH(1) })
withdrawalRewarderMock = await RewardEmulatorMock.new(deployed.withdrawalVault.address)
elRewarderMock = await RewardEmulatorMock.new(deployed.elRewardsVault.address)
await hre.ethers.getImpersonatedSigner(deployed.oracle.address)

await curatedModule.addNodeOperator('1', operator, { from: deployed.voting.address })
Expand All @@ -52,6 +57,8 @@ contract('Lido: handleOracleReport', ([appManager, , , , , , , stranger, another
voting = deployed.voting.address
oracle = deployed.oracle.address
oracleReportSanityChecker = deployed.oracleReportSanityChecker
withdrawalVault = deployed.withdrawalVault.address
elRewardsVault = deployed.elRewardsVault.address

await lido.submit(ZERO_ADDRESS, { from: stranger, value: ETH(30) })
await lido.submit(ZERO_ADDRESS, { from: anotherStranger, value: ETH(70) })
Expand Down Expand Up @@ -415,6 +422,20 @@ contract('Lido: handleOracleReport', ([appManager, , , , , , , stranger, another
'IncorrectAppearedValidators(101)'
)
})
})

describe('smooth report', async () => {
beforeEach(async () => {
await await lido.deposit(3, 1, '0x', { from: depositor })
await checkStat({ depositedValidators: 3, beaconValidators: 0, beaconBalance: 0 })
await checkBalanceDeltas({
totalPooledEtherDiff: 0,
treasuryBalanceDiff: 0,
strangerBalanceDiff: 0,
anotherStrangerBalanceDiff: 0,
curatedModuleBalanceDiff: 0
})
})

it('does not smooth if report in limits', async () => {
await oracleReportSanityChecker.setOracleReportLimits(
Expand Down Expand Up @@ -450,26 +471,217 @@ contract('Lido: handleOracleReport', ([appManager, , , , , , , stranger, another
)
await lido.handleOracleReport(0, ONE_YEAR, 3, ETH(100), 0, 0, 0, 0, { from: oracle, gasPrice: 1 })
await checkStat({ depositedValidators: 3, beaconValidators: 3, beaconBalance: ETH(100) })
await checkBalanceDeltas({
totalPooledEtherDiff: ETH(4),
treasuryBalanceDiff: ETH(4 * 0.05),
strangerBalanceDiff: ETH(4 * 0.3 * 0.9),
anotherStrangerBalanceDiff: ETH(4 * 0.7 * 0.9),
curatedModuleBalanceDiff: ETH(4 * 0.05)
})
})

it('does not smooth withdrawals if report in limits', async () => {
await withdrawalRewarderMock.reward({ value: ETH(1) })

await oracleReportSanityChecker.setOracleReportLimits(
{
churnValidatorsPerDayLimit: 100,
oneOffCLBalanceDecreaseBPLimit: 100,
annualBalanceIncreaseBPLimit: 10000,
shareRateDeviationBPLimit: 10000,
maxValidatorExitRequestsPerReport: 10000,
requestTimestampMargin: 0,
maxPositiveTokenRebase: 10000000,
maxAccountingExtraDataListItemsCount: 10000
},
{ from: voting, gasPrice: 1 }
)
await lido.handleOracleReport(0, ONE_YEAR, 3, ETH(96), ETH(1), 0, 0, 0, { from: oracle, gasPrice: 1 })
await checkStat({ depositedValidators: 3, beaconValidators: 3, beaconBalance: ETH(96) })
await checkBalanceDeltas({
totalPooledEtherDiff: ETH(1),
treasuryBalanceDiff: ETH(0.05),
strangerBalanceDiff: ETH(0.3 * 0.9),
anotherStrangerBalanceDiff: ETH(0.7 * 0.9),
curatedModuleBalanceDiff: ETH(0.05)
})
assert.equals(await ethers.provider.getBalance(withdrawalVault), 0)
})

// it('smooths withdrawals if report in limits', async () => {
// await ETHForwarderMock.new(deployed.withdrawalVault.address, { from: appManager, value: ETH(1) })

// await oracleReportSanityChecker.setOracleReportLimits(
// {
// churnValidatorsPerDayLimit: 100,
// oneOffCLBalanceDecreaseBPLimit: 100,
// annualBalanceIncreaseBPLimit: 10000,
// shareRateDeviationBPLimit: 10000,
// maxValidatorExitRequestsPerReport: 10000,
// requestTimestampMargin: 0,
// maxPositiveTokenRebase: 10000000,
// maxAccountingExtraDataListItemsCount: 10000
// },
// { from: voting, gasPrice: 1 }
// )
// await lido.handleOracleReport(0, ONE_YEAR, 3, ETH(96), ETH(1), 0, 0, 0, { from: oracle, gasPrice: 1 })
// await checkStat({ depositedValidators: 3, beaconValidators: 3, beaconBalance: ETH(97) })
// })
it('smooths withdrawals if report out of limit', async () => {
await withdrawalRewarderMock.reward({ value: ETH(1.1) })

await oracleReportSanityChecker.setOracleReportLimits(
{
churnValidatorsPerDayLimit: 100,
oneOffCLBalanceDecreaseBPLimit: 100,
annualBalanceIncreaseBPLimit: 10000,
shareRateDeviationBPLimit: 10000,
maxValidatorExitRequestsPerReport: 10000,
requestTimestampMargin: 0,
maxPositiveTokenRebase: 10000000,
maxAccountingExtraDataListItemsCount: 10000
},
{ from: voting, gasPrice: 1 }
)
await lido.handleOracleReport(0, ONE_YEAR, 3, ETH(96), ETH(1.1), 0, 0, 0, { from: oracle, gasPrice: 1 })
await checkStat({ depositedValidators: 3, beaconValidators: 3, beaconBalance: ETH(96) })
await checkBalanceDeltas({
totalPooledEtherDiff: ETH(1),
treasuryBalanceDiff: ETH(0.05),
strangerBalanceDiff: ETH(0.3 * 0.9),
anotherStrangerBalanceDiff: ETH(0.7 * 0.9),
curatedModuleBalanceDiff: ETH(0.05)
})

assert.equals(await ethers.provider.getBalance(withdrawalVault), ETH(0.1))
})

it('does not smooth el rewards if report in limit without lido fee', async () => {
await elRewarderMock.reward({ value: ETH(1) })

await oracleReportSanityChecker.setOracleReportLimits(
{
churnValidatorsPerDayLimit: 100,
oneOffCLBalanceDecreaseBPLimit: 100,
annualBalanceIncreaseBPLimit: 10000,
shareRateDeviationBPLimit: 10000,
maxValidatorExitRequestsPerReport: 10000,
requestTimestampMargin: 0,
maxPositiveTokenRebase: 10000000,
maxAccountingExtraDataListItemsCount: 10000
},
{ from: voting, gasPrice: 1 }
)
await lido.handleOracleReport(0, ONE_YEAR, 3, ETH(96), 0, ETH(1), 0, 0, { from: oracle, gasPrice: 1 })
await checkStat({ depositedValidators: 3, beaconValidators: 3, beaconBalance: ETH(96) })

await checkBalanceDeltas({
totalPooledEtherDiff: ETH(1),
treasuryBalanceDiff: 0,
strangerBalanceDiff: ETH(0.3),
anotherStrangerBalanceDiff: ETH(0.7),
curatedModuleBalanceDiff: 0
})

assert.equals(await ethers.provider.getBalance(elRewardsVault), ETH(0))
})

it('does not smooth el rewards if report in limit without lido fee', async () => {
await elRewarderMock.reward({ value: ETH(1.5) })

await oracleReportSanityChecker.setOracleReportLimits(
{
churnValidatorsPerDayLimit: 100,
oneOffCLBalanceDecreaseBPLimit: 100,
annualBalanceIncreaseBPLimit: 10000,
shareRateDeviationBPLimit: 10000,
maxValidatorExitRequestsPerReport: 10000,
requestTimestampMargin: 0,
maxPositiveTokenRebase: 10000000,
maxAccountingExtraDataListItemsCount: 10000
},
{ from: voting, gasPrice: 1 }
)
await lido.handleOracleReport(0, ONE_YEAR, 3, ETH(95.5), 0, ETH(1.5), 0, 0, { from: oracle, gasPrice: 1 })
await checkStat({ depositedValidators: 3, beaconValidators: 3, beaconBalance: ETH(95.5) })
await checkBalanceDeltas({
totalPooledEtherDiff: ETH(1),
treasuryBalanceDiff: 0,
strangerBalanceDiff: ETH(0.3),
anotherStrangerBalanceDiff: ETH(0.7),
curatedModuleBalanceDiff: 0
})

assert.equals(await ethers.provider.getBalance(elRewardsVault), ETH(0))
})

it('smooths el rewards if report out of limit without lido fee', async () => {
await elRewarderMock.reward({ value: ETH(1.1) })

await oracleReportSanityChecker.setOracleReportLimits(
{
churnValidatorsPerDayLimit: 100,
oneOffCLBalanceDecreaseBPLimit: 100,
annualBalanceIncreaseBPLimit: 10000,
shareRateDeviationBPLimit: 10000,
maxValidatorExitRequestsPerReport: 10000,
requestTimestampMargin: 0,
maxPositiveTokenRebase: 10000000,
maxAccountingExtraDataListItemsCount: 10000
},
{ from: voting, gasPrice: 1 }
)
await lido.handleOracleReport(0, ONE_YEAR, 3, ETH(96), 0, ETH(1.1), 0, 0, { from: oracle, gasPrice: 1 })
await checkStat({ depositedValidators: 3, beaconValidators: 3, beaconBalance: ETH(96) })
await checkBalanceDeltas({
totalPooledEtherDiff: ETH(1),
treasuryBalanceDiff: 0,
strangerBalanceDiff: ETH(0.3),
anotherStrangerBalanceDiff: ETH(0.7),
curatedModuleBalanceDiff: 0
})

assert.equals(await ethers.provider.getBalance(elRewardsVault), ETH(0.1))
})

it('does not smooth el rewards if report in limit', async () => {
await elRewarderMock.reward({ value: ETH(1) })

await oracleReportSanityChecker.setOracleReportLimits(
{
churnValidatorsPerDayLimit: 100,
oneOffCLBalanceDecreaseBPLimit: 100,
annualBalanceIncreaseBPLimit: 10000,
shareRateDeviationBPLimit: 10000,
maxValidatorExitRequestsPerReport: 10000,
requestTimestampMargin: 0,
maxPositiveTokenRebase: 10000000,
maxAccountingExtraDataListItemsCount: 10000
},
{ from: voting, gasPrice: 1 }
)
await lido.handleOracleReport(0, ONE_YEAR, 3, ETH(96.1), 0, ETH(0.9), 0, 0, { from: oracle, gasPrice: 1 })
await checkStat({ depositedValidators: 3, beaconValidators: 3, beaconBalance: ETH(96.1) })

await checkBalanceDeltas({
totalPooledEtherDiff: ETH(1),
treasuryBalanceDiff: ETH(0.05),
strangerBalanceDiff: ETH(0.3 * 0.9),
anotherStrangerBalanceDiff: ETH(0.7 * 0.9),
curatedModuleBalanceDiff: ETH(0.05)
})

assert.equals(await ethers.provider.getBalance(elRewardsVault), ETH(0.1))
})

it('smooths el rewards if report out of limit', async () => {
await elRewarderMock.reward({ value: ETH(1.1) })

await oracleReportSanityChecker.setOracleReportLimits(
{
churnValidatorsPerDayLimit: 100,
oneOffCLBalanceDecreaseBPLimit: 100,
annualBalanceIncreaseBPLimit: 10000,
shareRateDeviationBPLimit: 10000,
maxValidatorExitRequestsPerReport: 10000,
requestTimestampMargin: 0,
maxPositiveTokenRebase: 10000000,
maxAccountingExtraDataListItemsCount: 10000
},
{ from: voting, gasPrice: 1 }
)
await lido.handleOracleReport(0, ONE_YEAR, 3, ETH(96.1), 0, ETH(1.1), 0, 0, { from: oracle, gasPrice: 1 })
await checkStat({ depositedValidators: 3, beaconValidators: 3, beaconBalance: ETH(96.1) })
await checkBalanceDeltas({
totalPooledEtherDiff: ETH(1),
treasuryBalanceDiff: ETH(0.05),
strangerBalanceDiff: ETH(0.3 * 0.9),
anotherStrangerBalanceDiff: ETH(0.7 * 0.9),
curatedModuleBalanceDiff: ETH(0.05)
})

assert.equals(await ethers.provider.getBalance(elRewardsVault), ETH(0.2))
})
})
})