-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: allocation tests #520
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we DRY this two test files somehow?
They differ only in two lines and there is a ton of code to check it twice.
Good idea. Moved it to common tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Fixed merge conflicts. Got one test failure:
@mymphe could you have a look please? |
Changes:
- combine multiple test cases into a single unit test to prevent standard output flooding
- remove redundant test cases