Repository navigation
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Deterministic PR hygiene checks passed. |
⏳ DRAFT
What to do
Review readiness checklist
0/4 boxes ticked. This PR stays in draft until every box above is ticked. |
|
Superseded by #7142, which carries this work with Co-authored-by credit. Thank you! |
|
Thank you, @fwkyle. I've carried this onto an upstream branch in #7142, so the repository's full CI (including the macOS and Windows matrix) can run on it. Your commits are kept and credited with a |
#7142) * fix(cli): refuse uncertain ownership before publishing sibling runtime Carries #7119 (commit c5e17b5). Co-authored-by: fwkyle <cv271010@gmail.com> * fix(cli): isolate default-home owner discovery under test home guard Co-authored-by: fwkyle <cv271010@gmail.com> * fix(test): isolate owner registry under the armed home guard Resolve the guarded registry beneath the selected config home when its override is absent. Pin the sandbox registry for inherited children and reject protected paths for reads and retirement as well as publication. Co-authored-by: fwkyle <cv271010@gmail.com> --------- Co-authored-by: fwkyle <cv271010@gmail.com> Co-authored-by: GOAT <goat@localhost>
Summary
sibling_instanceuntil restart.Verification
Verified at
c5e17b50b2c3508d023c0ec560c7a1e2ca128812, based ondevat7640a942b35044c974e534b84d5a8049f4a8ae9a:OCX_TEST_RUNNER_BUN=<Bun 1.4.3 binary> bun run test:changed— 34 passed, 0 failed; selected 1 of 2,325 test files.bun test tests/cli/start-ownership-publication.test.ts tests/server/management-route-registry.test.ts— 29 passed, 0 failed, including management rejection boundaries and listener/runtime publication ordering.bun run typecheck,bun run structure:check,bun run privacy:scan, andgit diff --check origin/dev...HEAD— passed.cd docs-sitethenbun run build— passed; 577 pages and 81,203 internal links checked.sibling_instance; after applying the same runtime patch and restarting the service, the new runtime had no sibling mark and authenticatedPOST /api/syncreturned HTTP 200 withok: true,status: applied.The full local suite has not been run. This is a draft with focused validation; broader platform CI and maintainer security review remain pending. The historical cause of the original local connection delay is unknown; this change fixes the incorrect durable topology decision rather than weakening ownership verification or increasing probe timeouts.
Checklist
Maintainer security review requested for the ownership boundary. The change preserves fail-closed behavior; no authentication, attestation, or management-route permission is relaxed.
Review readiness checklist
Required local validation passed; commands, results, and any full-suite exception are documented.
I pushed my PR to the latest dev commit.
I resolved all correct Codex and CodeRabbit findings.
My PR is ready for review.
Review readiness checklist
This PR stays in draft until every box below is ticked. Tick all four boxes once the requirements are met:
Required local validation passed; commands, results, and any full-suite exception are documented.
I pushed my PR to a recent dev commit (at most 10 behind; a maintainer may still ask for the exact tip before merge).
I resolved all correct Codex and CodeRabbit findings.
My PR is ready for review.