Repository navigation
fix(zcode): bound default bootstrap file reads - #7039
Conversation
Use the shared integration reader for default ZCode bootstrap discovery. Preserve relocation and explicit data-root overrides, cover real-file boundaries, and document the bootstrap and fixture contracts. Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Deterministic PR hygiene checks passed. |
|
Maintainer integration (dev-only bypass per MAINTAINERS.md), not an independent approval. Exact head |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Summary
Default ZCode bootstrap discovery now uses the shared integration file reader. It accepts regular files up to 4 MiB and refuses oversized files, final symlinks (including dangling links), and FIFOs without blocking. Missing settings, valid settings without a relocation selector, ordinary relocation, and explicit
ZCODE_DATA_DIRoverrides retain their existing behavior.The bounded reader is already on
devthrough #7029. This change contains only the default bootstrap call site, its real-file regressions, and the integration documentation; it does not reintroduce the parent reader changes.Verification
Head:
e949ce2468155cece152f68e395c653bd6102ba4. Base:a5cd5a2b832d727cfef5e77c48547b47b1cbeebb. One commit, four changed files. Tests used the pinned Bun 1.4.3.bun run typecheck,bun run structure:check, andbun run privacy:scan: passed.cd docs-site && bun install --frozen-lockfile && bun run build: passed; 569 pages and 79,369 internal links checked. Existing syntax-highlighting, chunk-size, and missing-content warnings remain.Exact focused regression command
bun run test \ tests/providers/zcode-client.test.ts \ tests/lib/bounded-file-read.test.ts \ tests/clients/integrations-current-store.test.ts \ tests/clients/integrations-state.test.ts \ tests/clients/integrations-writer.test.ts \ tests/clients/integrations-writer-guard.test.ts \ tests/lab/core-lab-boundary.test.ts \ tests/ci-workflows/file-size-ratchet.test.ts \ tests/ci-workflows/repo-hygiene.test.ts \ tests/ci-workflows/structure-ssot.test.ts \ tests/test-layout.test.ts \ tests/test-layout-tooling.test.tsThis remains a draft. As of 2026-10-13 11:54 UTC, exact head
e949ce2468155cece152f68e395c653bd6102ba4had 34 successful check runs, 7 conditionally skipped, and no failures or pending checks. Cross-platform CI passed all 4 Linux and 9 Windows test shards; the macOS full-test lanes were conditionally skipped. Catalog async contracts passed on Linux, Windows, and macOS. PR processing, includingresolve-prandenforce-target, passed. CodeRabbit skipped review because this PR is a draft; its successful status does not mean a review was completed. Native Windows/macOS execution has not been performed locally. Local baseline equivalence is not a claim that the full suite passed.Checklist
Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>