Repository navigation
feat(cli): complete observation and explicit-key API workflows - #6545
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing (112)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Deterministic PR hygiene checks passed. |
…li-parity-observation-api
…li-parity-observation-api # Conflicts: # skills/ocx/references/01_surface_observe-system.md # src/cli/capabilities-base.ts # src/cli/capabilities-observe-system.ts
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 16f27e24f8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…li-parity-observation-api
…li-parity-observation-api
…li-parity-observation-api
…li-parity-observation-api
|
Current disposition (2026-10-04, 19:23 UTC): the owner has now merged all six CLI layers, ending at dev The outstanding D2/CLI decoder compatibility issue has moved to the still-open #6597: changes requested. Current dev's decoder is unchanged from the exercised f108061 file and does not accept the new structured refusal fields. Please fix that constrained consumer contract in the open PR before it lands. This is not a released-dev D2 failure claim, and none of this records a blanket semantic or independent-boundary approval by me. Historical checkpoints: The owner merged #6526 ( Cross-platform CI has completed successfully at these exact branch heads:
These receipts do not complete my outstanding semantic review or authorize a required independent-boundary review waiver. Retargeted/combined diffs still need their own review. One new combined-change issue is now reproduced, not merely a checklist concern: #6542's closed CLI decoder rejects #6597's structured Earlier checkpoints below are historical: This is CI follow-up, not completion of my substantive CLI management/data-key/consent review. No blanket approval, independent-review waiver, scan or integration from me. After a parent lands, recheck the child target and resulting diff. Earlier checkpoint (historical): Latest stack refresh: #6526 270c33c -> #6528 24ca58e -> #6535 adf8574 -> #6539 04a639e -> #6542 b63ced6 -> #6545 b9b6b53. Current Cross-platform CI37220126973 /37220129579 /37220129931 /37220129595 /37220129675 /37220129489 is queued at this checkpoint. Cancelled duplicates are not passing receipts. The previous six successful runs below are now old-head evidence after these pushes. The substantive CLI management/data-key/consent review remains outstanding; no blanket approval, independent review waiver, scan or integration from me. Keep the open-parent chain and recheck the child target/resulting diff after each parent lands. Earlier checkpoint (historical): Latest exact-head stack checkpoint (2026-10-04): #6526 e3ff9fd -> #6528 697cc9e -> #6535 7d23f8a -> #6539 f812563 -> #6542 b6cd273 -> #6545 e950893. Cross-platform CI respectively 37217206971 /37217207354 /37217206834 /37217207247 /37217207353 /37217206368 now all completed success. The cancelled duplicate runs on these heads are not passing receipts, and their cancelled jobs do not establish a new runtime regression. This completes the CI-status follow-up, not my substantive semantic review of the large CLI stack. That review remains outstanding; no approval, independent boundary-review waiver, scan, live CLI/account operation or integration performed. Preserve the open-parent chain and recheck the child target/resulting diff after a parent lands. Earlier checkpoint (historical): Latest stack checkpoint: #6526 4bcd561 → #6528 c08bbca → #6535 8a6dc57 → #6539 95868c7 → #6542 ea4b1c6 → #6545 7b1b7a4 now carries dev dabaed4 through the open-parent chain. Current-head CI37215554618 /37215553610 /37215552563 /37215553740 /37215553258 /37215553269 is queued or in progress at this checkpoint. The previous stack's CI37213715031 /37213715562 /37213715527 /37213716123 /37213715917 /37213716090 all completed success, but these are old-head receipts after the new refresh. Cancelled duplicates are not passes. The substantive semantic review of CLI management/data-key/consent workflows remains outstanding; no blanket approval or required independent review waiver. After parent integration, recheck child target/diff and the combined help/config/fixture contracts. Historical checkpoint: The substantial semantic review is still outstanding; no approval or independent boundary-review waiver has been issued by me. Refresh the head-bound verification and use the new completed runs when available; after parent integration, recheck the retargeted child diff/union. Historical intake checkpoint: Current #6545 head is 146994d, base fad6f66 (open #6542). The final Green CI and author-recorded independent-review receipts do not mean I have completed semantic review of all new CLI management/data-key/consent workflows. That substantive review remains outstanding; no blanket approval, boundary-review waiver, fresh scan, live CLI/account operation, integration or deployment is being claimed. |
…li-parity-observation-api
…li-parity-observation-api Resolve test-layout registry conflict as a union: both sides only added entries.
Four entries per line for the entries this layer adds, leaving every pre-existing line untouched. scripts/test-layout/layout.json sits near the 2000-line unbaselined threshold once the whole stack lands.
…li-parity-observation-api
…li-parity-observation-api
…li-parity-observation-api
…li-parity-observation-api
|
Maintainer integration (lidge-jun, dev only) — 2026-10-04 landing train, lane L1 stack.
|
2 participants
Summary
Manual stack: #6526 → #6528 → #6535 → #6539 → #6542 → this PR. Depends on #6542; review this layer only. Each branch contains its current parent and pinned dev
0818ea1812a028e1c14cd0b0511b44863407bc52. No native stack registration, PR merge, release or deployment.Verification
Stack refresh onto dev (lane L1, 2026-10-04; re-refreshed 2026-10-05 onto dev
df61d03ecc), heade95089386af389ae0e36f3c632b5dc3ce7de3588. Merged the refreshed parent; clean merge. With #6583 the test-layout fixture is 1126 lines at this head (it was 2002 against current dev without it), and every capped file the stack touches stays at or under its cap. Independent security review (gpt-6.1-sol): PASS at9ff863704d(explicit keys only via bounded piped stdin, argv secrets rejected, redirects refused, no admission bypass, management auth retained); own diff confirmed unchanged after the refresh at85aaeafdad; the later merged delta only carries the #6539 pool fixes, re-reviewed PASS. Local checks at this head:bun scripts/file-size-ratchet.ts(pass; test-layout fixture now well under the 2000-line threshold after #6583),tests/test-layout.test.ts+tests/test-layout-tooling.test.ts(pass),bun run typecheck(pass),bun run structure:check(pass); on the stack top additionallyskill:surface:check,privacy:scanand the skill/capability/ratchet test files (all pass). The full local suite was intentionally not run per maintainer instruction; broad and platform coverage is left to exact-head hosted CI: Cross-platform CI run 37217206368 (success at this head). Earlier-head CI results below are historical. Later dev moves (#6576, #6578, #6405, #6486, #6512, #6572, #6585, #6586, #6564) were merged in the same way; test-layout fixture conflicts were resolved as key unions, and this layer now packs only its own new entries inscripts/test-layout/layout.jsonfour per line (JSON content unchanged; the file stays clear of the 2000-line threshold for unbaselined files once the stack lands).devlog/_fin/261003_cli_gui_parity/072_observation_verification.md,084_acceptance_evidence.md,085_residual_verification.mdand086_review_reconciliation.md. Historical failed runs remain identified as failures.Current head:
9ff863704d8247a66f56e941569a5c4976c60054.Checklist
All six current manual-stack heads passed their applicable CI. The task remains open for review; no PR was merged.