Repository navigation
fix(chatgpt): say why a dropped chatgptDesktop block reads as off #6486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
lidge-jun
merged 9 commits into
lidge-jun:dev
from
lcxhh521:fix/chatgpt-desktop-config-reason
Oct 4, 2026
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
9d8bc67
fix(chatgpt): say why a dropped chatgptDesktop block reads as off
lcxhh521 b25ec4f
Merge dev into the chatgptDesktop config-reason branch
lcxhh521 daa6ecc
fix(chatgpt): explain a dropped chatgptDesktop block without loading …
lcxhh521 c1303a8
test(chatgpt): cover the status and launch messages for a dropped cha…
lcxhh521 9791dab
test(chatgpt): name the config input in the plain-off status loop
lcxhh521 439346f
Merge dev into the chatgptDesktop config-reason branch
lcxhh521 f560d93
Merge remote-tracking branch 'origin/dev' into HEAD
lidge-jun 6ded1ee
fix(config): report dropped chatgptDesktop reason on salvaged diagnos…
lidge-jun 45d7cbc
Merge remote-tracking branch 'origin/dev' into HEAD
lidge-jun File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| import * as z from "zod/v4"; | ||
| import { redactSecretString } from "../../lib/redact"; | ||
|
|
||
| /** Experimental macOS ChatGPT app-server shim; only a strict optional boolean is accepted. */ | ||
| export const chatgptDesktopSchema = z.object({ appServerShim: z.boolean().optional() }).strict(); | ||
|
|
||
| /** | ||
| * Why a present `chatgptDesktop` block fails the schema, or null when it is valid or absent. The | ||
| * read path degrades a failing block to absent, so the integration reads as off while the file | ||
| * still says `appServerShim: true`; this names the field so that is never silent. A leftover key | ||
| * from an older or ported config (for example `unblockSend`) is the usual cause. | ||
| */ | ||
| export function chatgptDesktopConfigIssue(rawParsed: unknown): string | null { | ||
| if (!rawParsed || typeof rawParsed !== "object" || Array.isArray(rawParsed)) return null; | ||
| const block = (rawParsed as Record<string, unknown>).chatgptDesktop; | ||
| if (block === undefined) return null; | ||
| const result = chatgptDesktopSchema.safeParse(block); | ||
| if (result.success) return null; | ||
| const issue = result.error.issues[0]; | ||
| const field = issue?.path.join("."); | ||
| return redactSecretString(`chatgptDesktop${field ? `.${field}` : ""}: ${issue?.message ?? "invalid configuration"}`); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.