Repository navigation
fix(cli): carry oocheol's CLI validation and diagnostics fixes (#6429 #6431 #6432 #6433 #6434 #6435 #6437 #6438) - #6447
Conversation
Amends the #6433 carry: an invalid interactive port now reports the error and re-asks, so a typo no longer discards every earlier answer. EOF and SIGINT at the repeated prompt still cancel without saving (exit 1 / 130); the wizard tests cover all three paths. Co-authored-by: 정우철 <oocheol@naver.com>
Follow-up to the #6438 carry: encrypted-output resend and quota alternate-account detection now see a fallback message hidden behind a blank primary one; a nonblank primary still wins. Co-authored-by: 정우철 <oocheol@naver.com>
Co-authored-by: 정우철 <oocheol@naver.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. 🧰 Additional context used📚 Code guidelines (2)No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: lidge-jun/opencodex/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (28)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 5 remain after this review. 📝 WalkthroughWalkthroughThe CLI now validates arguments, config input, integer options, and initialization ports more strictly. Human-readable logs include safe request IDs. Missing route-policy profiles and upstream error messages use updated diagnostic handling. Tests and reference documentation cover these changes. ChangesCLI contracts
Priority: ➖ Normal Estimated code review effort: 3 (Moderate) | ~25 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to The setup prompt’s whitespace behavior matches its tested behavior, and no issue identified here prevents merging after normal checks. Security Architecture ReviewSecurity architecture risk: 🔵 Low · up to The reviewed changes tighten input handling, and the inspected configuration and recovery paths retain important ownership and replay controls. No new security weakness was established, but incomplete historical and recovery-path verification prevents a minimal-risk assessment. Retained concerns Security review detailsSecurity Blast Radius
Trust Boundaries and Controls
Resilience and Maintainability Implications
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 70.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 20 functions across 16 files. (12 skipped: 12 unsupported.)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Deterministic PR hygiene checks passed. |
|
Maintainer integration decision (dev, admin bypass per MAINTAINERS.md): merging at exact head 283bc4a.
|
Summary
Carries eight small CLI and diagnostics fixes by @oocheol into one PR so they land together on current
dev. Each source PR is one commit authored by oocheol; three small follow-up commits sit on top.ocx capabilitiesrejects unknown arguments, repeated flags and blank--routewith exit 64, so a mistyped filter no longer prints the full list and exits 0.ocx config validateandocx config importaccept UTF-8 JSON with a leading BOM (Windows PowerShell exports).ocx initvalidates the setup port (1–65535, decimal) instead of silently truncating10100oopsto 10100.ocx alias --jsonworks without an explicitlistaction.ocx logsoutput showsid=<request-id>for use withocx logs explain.ocx route policy show <id>exits 4 (not found) for a missing profile instead of 2 (usage).error.messageno longer hides a usable fallback.The follow-up commits change one thing in #6433 and add coverage for #6438:
structure/runtime.mddescribe the new behavior.core-opaque-recovery.ts) and quota alternate-account detection (core-codex-account.ts). Behind a blank primary message, both now see the fallback text. That is the intent of the fix, and the new tests pin it, including that a nonblank primary message still wins. Relay code selection uses its own candidate scan and is unchanged.reference/cli.mdandreference/cli/agents.md(en, ko) conflicted at the same insertion point. Every section is kept exactly once, with normal spacing.#6436 (
ocx usage --top) is not included because it needs a product decision first.Co-authored-by: 정우철 oocheol@naver.com
Verification
Checklist
Summary by CodeRabbit
--jsonin different argument positions. Capability and route-policy commands provide clearer handling of invalid arguments and missing profiles.