Repository navigation
fix(gui): keep native login confirmation readable and contained - #6388
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. 🧰 Additional context used📚 Code guidelines (1)No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: lidge-jun/opencodex/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe confirmation panel now displays as a block. Its action row and buttons wrap long text and remain constrained to the container width. A new rendering test checks these layout properties and confirms the primary button remains disabled. ChangesConfirmation panel layout
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~8 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to The change is limited to confirmation-panel layout, with no concrete regression established. Proceed with normal CI checks; the reported browser geometry check was not independently rerun here. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Deterministic PR hygiene checks passed. |
✅ READY
Review readiness checklist
✅ 4/4 boxes ticked. This pull request is already Ready for Review. |
|
Maintainer integration record (MAINTAINERS.md, dev-only)
|
Summary
The native-login confirmation inherits a horizontal flex layout from the shared warning notice. German copy and a home path collapse into narrow columns, while the confirm button overflows the panel.
Addresses the layout portion of #6387. Account-switch workflow changes remain outside this PR.
Verification
cd gui && bun test tests: 2704 passed, 0 failed across 309 files, including the new regression and existing native-profile/session tests.display: flex); with the fix: passed.cd gui && bun run lint: passed.cd gui && bun run build: passed; existing large-chunk warning remains.bun run typecheck: passed.git diff --check: passed.The repository-wide backend suite was not run: this four-line styling change does not change backend logic, and the complete GUI suite plus root typecheck cover the affected surface. Remaining repository-wide coverage is left to CI; fork CI may require maintainer approval.
Anonymized fixture screenshots at 1440px / 110%, using the same production stylesheet. These images live on the fork's separate
pr-assetsbranch, not in the PR diff.Before:
After:
Checklist
Review readiness checklist
Required local validation passed; commands, results, and any full-suite exception are documented.
I pushed my PR to a recent dev commit (at most 10 behind; a maintainer may still ask for the exact tip before merge).
I resolved all correct Codex and CodeRabbit findings.
My PR is ready for review.
Summary by CodeRabbit