Repository navigation
docs(devlog): open the round 2 follow-up unit - #5325
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
✅ Deterministic PR hygiene checks passed. |
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Repository: lidge-jun/opencodex/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d4e1755033
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| | Item | What is left | | ||
| | --- | --- | | ||
| | #5292 | `gui/src/pages/Logs.tsx` restates the recovery-kind union with nine of thirteen members, so four durable kinds have no label. The fix derives the GUI union from the roster instead of restating it. | |
There was a problem hiding this comment.
Remove the already-fixed #5292 item
At this commit's parent, gui/src/pages/Logs.tsx already imports AttemptRecoveryKind from the durable telemetry contract and defines an exhaustive RECOVERY_KIND_KEYS mapping containing all thirteen members; tests/usage/request-outcome-agreement.test.ts also verifies that every durable kind has a dashboard label. The described nine-member restatement was fixed by 555f0cac, so listing it as remaining work and assigning it to R3 would send that lane after a defect that no longer exists; remove it or replace it with the actual unresolved portion of #5292.
Useful? React with 👍 / 👎.
| Unchanged. One branch, ordered commits, one pull request to `dev` per lane. No native stack — the | ||
| desktop chain proved why: squashing the bottom of one detaches every child and the remaining work | ||
| has to be reconstructed. Carried contributor work needs a `Co-authored-by` trailer. No local | ||
| suites, typecheck, builds, installs or live `ocx` execution; verification is static review plus |
There was a problem hiding this comment.
Restore the required verification steps
This constraint directs every behavior-changing lane to skip all local suites and typechecking in favor of hosted CI, but non-trivial PRs must run bun run typecheck and bun run test before becoming review-ready. Revise the constraint to permit the required focused implementation checks and PR-ready gates; otherwise these lanes cannot follow the repository's mandatory verification workflow.
AGENTS.md reference: AGENTS.md:L234-L236
Useful? React with 👍 / 👎.
Summary
devlog/_plan/260920_round2_followups/for the work the post-2.60.0 batch left behind, plus two things it caused.macos widget + bundlecheck ondev. The appex and bundle build;tauri buildrefuses because the updater public key is committed without a private key in CI. That is configuration, and release signing belongs to the release workflow rather than a verification build.Verification
src/codex/history-provider.tsat the currentdevhead, and the CI failure from the job log of the run ondev.Checklist