Skip to content

chore(release): open dev at 2.58.0 before releasing 2.57.0 - #4827

Merged
lidge-jun merged 1 commit into
devfrom
codex/dev-version-2.58.0
Sep 16, 2026
Merged

lidge-jun merged 1 commit into
devfrom
codex/dev-version-2.58.0

Conversation

@github-actions

@github-actions github-actions Bot commented Sep 16, 2026 •

Copy link
Copy Markdown
Contributor

Summary

2.57.0 is about to be released. Merging this first means dev already outranks the new tag when it lands, so neither dev nor any open pull request ever inherits the version-line failure. release.yml refuses to publish until this has merged.

This moves dev to 2.58.0.

Opened automatically by .github/workflows/dev-version-bump.yml. The same
version-line move was previously done by hand in 32529c2, e4a85d1, 076ad30, and
befcac3.

Verification

The workflow proved 2.57.0 has neither a Git tag nor an npm publication, and bun test tests/ci-workflows/release-version-line.test.ts proved the chosen development version is unused.

Checklist

  • Scope stays focused and avoids unrelated cleanup.
  • Docs or release notes were updated when needed.
  • Security-sensitive changes were reviewed for secrets, auth, and unsafe defaults.

Review readiness checklist

This PR stays in draft until every box below is ticked. Tick all four boxes once the requirements are met:

  • All CI tests are green on my local testing.

  • I pushed my PR to the latest dev commit.

  • I resolved all correct Codex and CodeRabbit findings.

  • My PR is ready for review.

@coderabbitai

coderabbitai Bot commented Sep 16, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: dc6b0526-8c64-451b-aaa0-32c9649e118a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 16, 2026 •

Copy link
Copy Markdown
Contributor Author

⏳ DRAFT

  • hygiene: unsponsored_surface.

What to do

  • Fix unsponsored_surface — This changes an authentication, workflow, release-automation, or dependency surface. MAINTAINERS.md requires security review for these; ask a maintainer to apply maintainer-sponsored once they have reviewed it. Paths: package.json.
  • Tick all four boxes in the PR description once you're done (currently 0/4).

Review readiness checklist

  • ⬜ All CI tests are green on my local testing.
  • ⬜ I pushed my PR to the latest dev commit.
  • ⬜ I resolved all correct Codex and CodeRabbit findings.
  • ⬜ My PR is ready for review.

0/4 boxes ticked.

Automatic draft conversion failed (token cannot change draft status). Please convert this pull request to a draft manually. The required enforce-target check will keep failing until every issue above is resolved.

@lidge-jun

Copy link
Copy Markdown
Owner

리뷰 · 우선순위 78 / 80

이 PR은 package.json의 version 한 줄만 2.57.0 → 2.58.0으로 올린다. 방금 dev에 들어간 #4828 릴리스 트레인 문서(000_roadmap.md)가 말하는 2단계와 같다. 2.57.0을 main에 올리기 전에 dev 버전을 한 칸 더 열어 둬야, release.yml의 assert-ahead <dev version> <release version> 게이트가 통과하고, 릴리스 직후 dev와 열린 PR들이 “방금 자른 태그 버전”을 물려받아 깨지는 일을 막는다. 워크플로 .github/workflows/dev-version-bump.yml이 자동으로 연 PR이고, 예전에 손으로 하던 같은 이동(본문에 인용된 옛 커밋들)을 자동화한 것이다.

현재 dev HEAD d78be30da는 아직 2.57.0이다. 이 PR head는 2.58.0이다. diff는 package.json 한 파일이고 additions/deletions가 1/1이다. 제품 로직·테스트·워크플로 변경은 없다. #4828이 적어 둔 제약(“로컬 풀 스위트/타입체크/빌드/인스톨 금지, hosted CI만 증거”)과도 맞다. 본문 verification도 “2.57.0 태그와 npm 출판이 아직 없다”와 bun test tests/ci-workflows/release-version-line.test.ts로 골랐다는 점을 밝힌다.

릴리스 순서상 이 PR을 안 머지하고 2.57.0을 먼저 자르면, 문서가 경고한 대로 dev가 다시 버전 라인 실패를 물려받는다. 그래서 우선순위가 높다. 다만 머지 조건은 “버전 숫자만 맞다”가 아니라 정확한 head에서 제품 CI가 초록이어야 한다. #4828의 020_pr_triage.md가 반복한 그 규칙이다, 정책 체크 네 개만 초록인 채로 넣으면 안 된다. 이 글을 쓰는 시점에는 일부 test/macos shard가 아직 진행 중이었다.

package.json version 줄 — 내용 자체는 맞다. 문제는 이 줄이 아니라, 머지 타이밍이 2b19983bfd 후보의 그린 Cross-platform 재실행과 #4828이 예고한 040_release.md 기록과 맞춰져 있는지다.

PR 본문 Review readiness checklist — 자동 생성 체크리스트가 아직 비어 있다. 봇이 연 1줄 범프 PR이라 실무상 무시하는 경우가 많지만, 사람이 “드래프트/미완”으로 오해하지 않게 상태를 정리해 두는 편이 낫다.

메인테이너의 판단이 필요한 지점

  • 후보 2b19983bfd의 Cross-platform 그린 run을 이 범프 전에 확보할지, 범프 머지 후 tip에서 다시 잡을지(문서는 후보 freeze → 버전 범프 → 후보를 main으로 promote 순서).
  • 범프 머지 직후 tip이 d78be30da+version이 되므로, release.yml의 expected-sha는 어디까지나 main promotion 커밋이어야 하고 dev tip이 아님을 한 번 더 확인할지.
  • checklist 미체크를 무시하고 머지할지.

너의 추천
정확한 head에서 Cross-platform(및 이 PR에 필요한 product test)이 초록이 되는 즉시 머지하라. 그다음 #4828 로드맵대로 후보 2b19983bfd(또는 문서에 확정한 freeze SHA)를 main으로 promote하고 release.yml을 expected-sha와 함께 돌린다. 이 PR을 기다려 dev가 2.57.0인 채로 태그를 먼저 자르지 말 것.

이 댓글은 grok-bot이 작성했습니다

@lidge-jun

Copy link
Copy Markdown
Owner

Maintainer integration into dev under the 2026-09-06 owner authorization in MAINTAINERS.md, not a self-approval.

Exact head e01e08822e065775d29779a6a7a7c0468c1554ac, Cross-platform CI run 35127440220: success after a rerun of a cancelled macos 1/2 job, and Service lifecycle run 35127440065: success. This is the version pre-move release.yml's assert-ahead gate requires before 2.57.0 can publish.

@lidge-jun
lidge-jun marked this pull request as ready for review September 16, 2026 18:14
@lidge-jun
lidge-jun merged commit 3f639df into dev Sep 16, 2026
47 of 49 checks passed
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 16, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-16T18:16:57.239066Z e01e088 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@lidge-jun
lidge-jun deleted the codex/dev-version-2.58.0 branch September 16, 2026 18:14
agentHits pushed a commit to agentHits/opencodex that referenced this pull request Sep 17, 2026
…#4827)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant