test(update): expose detached recovery failure evidence - #3623
Conversation
…ctations Fix concrete final-dev Linux shards 1/4 and 2/4 failures at 55395a9. Keep lazy namespace dispatch, declare the existing endpoint and CLI verb, regenerate the capability surface, and retain the new observation timestamp in the existing exact-object regression. No local tests run; hosted Linux rerun is the execution gate.
Fix the real Linux 3/4 and macOS failure: the activation fixture wrote an HTTP URL that production config validation correctly rejected. Keep a valid synthetic HTTPS config and adapt only its transport to the real loopback receiver; restore fetch after the test. No production policy weakening and no local test execution.
Instrument only the copied launcher: preserve the real detached restart while capturing owner-only stdout/stderr and child exit records. Emit allowlisted bounded diagnostics on the existing readiness failure without changing budgets, expectations, or teardown. Static checks only; no local tests or live launcher execution.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
✅ Deterministic PR hygiene checks passed. |
Owner-authorized diagnostic follow-up for the actual Linux restart failure. Only the fixture launcher is instrumented; production behavior, assertions and time budgets unchanged. Raw output redacted. No local tests; next dev HEAD CI is the execution gate.
Summary
Captures the evidence missing from the actual Linux 4/4 update-restart failure in final dev run 33943525788. Only the copied test launcher is instrumented: owner-only temporary files record the detached child output and exit status; readiness failure emits bounded allowlisted categories, source frames and runtime-file presence.
This does not claim a production fix yet. The original assertions, time budgets, real restart and teardown are unchanged. Raw output, tokens and request bodies are not printed.
Stack: depends on #3622; merge bottom-up, then inspect the final dev run.
Verification
Checklist