docs(devlog): dashboard-minimal roadmap — inventory, three reviewer opinions, decisions, nine decade docs - #3381
Conversation
…pinions, decisions, nine decade docs Docs-only unit. Inventory of all 16 dashboard routes (ko, 1440px, live proxy captures), three independent read-only reviews (claude-fable via the sol slot, claude-opus-5, grok-4.6) with a disagreement table, 51 merged keep/remove/collapse verdicts, and one diff-level decade doc per implementation phase in dependency order: sidebar footer, dashboard home, models catalog, integrations, codex-set cards, usage, startup, page polish, i18n prune + docs sync.
…, effort-cap rehome, v2 state kept, tab collapse rule, a11y tooltips, combos CTA, locale paths, star button mount
…n CSS, UltraMode contract per phase, rehome tests, Tooltip child, usage.subtitle kept
…onstructor sites, Tooltip accessible name
…dance keys stay consumed)
|
Warning Review limit reachedNext included review available in 5 minutes. View limit detailsLimit details: You’ve used all 10 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: ⛔ Files ignored due to path filters (16)
📒 Files selected for processing (45)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
✅ Deterministic PR hygiene checks passed. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1245cb64ff
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| Evidence: `assets/<route>_1440.png` (full page, ko, 1440 px headless Chrome against the live | ||
| proxy), `assets/<route>_text.txt` (visible text), `assets/<route>_interactive.txt` (interactive |
There was a problem hiding this comment.
Redact account data from the raster captures
The text captures were redacted, but the committed PNGs still contain the original data: codex-set_1440.png exposes masked real email addresses, account-ID suffixes, plans, quotas, and reset times, while dashboard_providers_1440.png exposes the private provider URL http://100.100.125.116:8081/v1. Because privacy:scan only examines text files, it passes without detecting these rasterized disclosures; redact or regenerate the images before publishing this public devlog.
AGENTS.md reference: AGENTS.md:L91-L94
Useful? React with 👍 / 👎.
| - The client-state source: Integrations.tsx does not load client states today (the overview | ||
| does). Lift `useClientStates`-equivalent one level: check `IntegrationsOverview.tsx:298` | ||
| (`clients`, `installedFileClients`) and its resource hook; move the hook call to | ||
| Integrations.tsx and pass `clients` down as a prop to the overview (keeps one fetch). |
There was a problem hiding this comment.
Include native clients in primary-tab classification
When Codex, Claude, Grok, or Cursor is detected or applied, lifting only the overview's clients resource cannot classify its tab as primary: that resource comes from loadIntegrationStates and contains only file clients, while these native states are assembled separately by the Codex/Claude/Grok/Cursor/native resources in IntegrationsOverview.tsx. Consequently currently applied native clients are hidden under “More clients,” contrary to the stated primary rule; lift the assembled overview rows or equivalent native status data and cover an applied native client in the test fixture.
Useful? React with 👍 / 👎.
| - Order hint `<p className="swi-featured-hint">` → `Tooltip` on the "5/5" counter (content | ||
| keeps the `<Trans k="sub.orderHint" cmd="spawn_agent"/>`). |
There was a problem hiding this comment.
Give the order-hint tooltip a descriptive name
Wrapping the existing 5/5 counter directly in Tooltip makes the component's generated button accessible only as “5/5,” because Tooltip derives its trigger name from its children and supplies no aria-label. Screen-reader users therefore encounter an unexplained numeric button rather than an order-help control; add an explicit localized accessible label or visually hidden label, as the Usage tooltip plan already does.
Useful? React with 👍 / 👎.
…pinions, decisions, nine decade docs (lidge-jun#3381) * docs(devlog): dashboard-minimal roadmap — inventory, three reviewer opinions, decisions, nine decade docs Docs-only unit. Inventory of all 16 dashboard routes (ko, 1440px, live proxy captures), three independent read-only reviews (claude-fable via the sol slot, claude-opus-5, grok-4.6) with a disagreement table, 51 merged keep/remove/collapse verdicts, and one diff-level decade doc per implementation phase in dependency order: sidebar footer, dashboard home, models catalog, integrations, codex-set cards, usage, startup, page polish, i18n prune + docs sync. * docs(devlog): fold the roadmap audit round 1 (8 blockers) into the decade docs * docs(devlog): fold roadmap audit round 2 (9 defects): 002 consistency, effort-cap rehome, v2 state kept, tab collapse rule, a11y tooltips, combos CTA, locale paths, star button mount * docs(devlog): fold roadmap audit round 3: explicit star mount, chevron CSS, UltraMode contract per phase, rehome tests, Tooltip child, usage.subtitle kept * docs(devlog): fold roadmap audit round 4: d.apiBase, multiAgentMode constructor sites, Tooltip accessible name * docs(devlog): narrow the 090 orphan expectation (star + multiAgentGuidance keys stay consumed) * docs(devlog): record the five roadmap audit rounds (wp0 B artifact) * docs(devlog): redact addresses from the dashboard capture dumps (privacy:scan) --------- Co-authored-by: jun <jun@lidge.dev>
…pinions, decisions, nine decade docs (lidge-jun#3381) * docs(devlog): dashboard-minimal roadmap — inventory, three reviewer opinions, decisions, nine decade docs Docs-only unit. Inventory of all 16 dashboard routes (ko, 1440px, live proxy captures), three independent read-only reviews (claude-fable via the sol slot, claude-opus-5, grok-4.6) with a disagreement table, 51 merged keep/remove/collapse verdicts, and one diff-level decade doc per implementation phase in dependency order: sidebar footer, dashboard home, models catalog, integrations, codex-set cards, usage, startup, page polish, i18n prune + docs sync. * docs(devlog): fold the roadmap audit round 1 (8 blockers) into the decade docs * docs(devlog): fold roadmap audit round 2 (9 defects): 002 consistency, effort-cap rehome, v2 state kept, tab collapse rule, a11y tooltips, combos CTA, locale paths, star button mount * docs(devlog): fold roadmap audit round 3: explicit star mount, chevron CSS, UltraMode contract per phase, rehome tests, Tooltip child, usage.subtitle kept * docs(devlog): fold roadmap audit round 4: d.apiBase, multiAgentMode constructor sites, Tooltip accessible name * docs(devlog): narrow the 090 orphan expectation (star + multiAgentGuidance keys stay consumed) * docs(devlog): record the five roadmap audit rounds (wp0 B artifact) * docs(devlog): redact addresses from the dashboard capture dumps (privacy:scan) --------- Co-authored-by: jun <jun@lidge.dev>
Summary
Docs-only unit
devlog/_plan/260904_dashboard_minimal/: the roadmap for making the dashboard minimal without losing capability.000_inventory.md— every route captured (ko, 1440 px, live proxy): screenshot, visible text, interactive controls, with counts.001_subagent_opinions.md— three independent read-only reviews (claude-fable via the sol slot, claude-opus-5, grok-4.6), each with per-element verdicts, a top-15, and a do-not-touch list; agreement and disagreement tables up front.002_decisions.md— 51 merged keep/remove/collapse verdicts with votes and owner phase, the two contested items recorded as asks, a nine-phase dependency-ordered map, the PR-ready gate note and the a11y rule (no information moves to atitlealone; disclosures are labelled disclosures, never called menus).003_audit_record.md— five audit rounds by one reviewer (8 → 9 → 3 → 3 → 0 blockers) and which commit folded each.010–090— one diff-level decade doc per implementation phase: sidebar footer, dashboard home, models catalog, integrations, codex-set cards, usage, startup, page polish, i18n prune + docs sync.No
gui/orsrc/change in this PR. Capture dumps are redacted (privacy:scangreen).Verification
Checklist