-
Notifications
You must be signed in to change notification settings - Fork 1.3k
fix(adapters): annotate empty tool outputs, keeping an explicit provider false #2978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
a292ca7
feat(adapters): annotate present-but-empty tool outputs (DeepSeek def…
harryzhou2000 4f39a87
fix(adapters): annotate whitespace-only text-part arrays on the chat …
harryzhou2000 5a0c416
test(adapters): cover orphaned empty tool results on the chat wire
harryzhou2000 8dc4c7b
docs(types): end the annotateEmptyToolOutputs comment sentence
harryzhou2000 575aaad
fix(adapters): never annotate non-text Responses tool outputs; shared…
harryzhou2000 a959415
fix(adapters): treat Responses input_text/output_text parts as wire t…
harryzhou2000 87546a6
fix(adapters): annotate empty tool outputs before stateless orphan re…
harryzhou2000 dbcb466
fix(adapters): never annotate missing/null tool outputs; pin DeepSeek…
harryzhou2000 acea0bb
fix(management): validate annotateEmptyToolOutputs off the auth surface
harryzhou2000 62405f0
fix(management): redact provider name in annotation error; support PA…
harryzhou2000 5fff7a6
fix(management): keep an explicit annotateEmptyToolOutputs: false thr…
lidge-jun b6efdc0
fix(management): let canonical OpenAI own the annotateEmptyToolOutput…
lidge-jun 07b89cd
test(management): exercise the canonical seed path in the PATCH regre…
lidge-jun 88bd5c9
test(management): target the real PATCH route in the canonical regres…
lidge-jun 5958dc7
docs: describe the annotateEmptyToolOutputs provider option
lidge-jun 5933125
docs: localize the annotateEmptyToolOutputs provider contract
lidge-jun File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Document that only OpenAI-family adapters use
annotateEmptyToolOutputs. The option is read only byopenai-chatandopenai-responses; other adapters ignore it.docs-site/src/content/docs/fr/reference/configuration/providers.md#L104-L104: State theopenai-chatandopenai-responsesrestriction.docs-site/src/content/docs/ja/reference/configuration/providers.md#L92-L92: State theopenai-chatandopenai-responsesrestriction.docs-site/src/content/docs/zh-tw/reference/configuration/providers.md#L72-L72: State theopenai-chatandopenai-responsesrestriction.As per path instructions, “user-facing docs stay in sync with actual CLI/API behavior.”
🧰 Tools
🪛 LanguageTool
[style] ~104-~104: Le sujet semble être manquant. Dans un souci de clarté, le sujet est généralement placé avant le verbe.
Context: ... ne soit pas interprété comme manquant. S’applique aux chaînes vides et aux tableaux de pa...
(SUJET_MANQUANT)
[typographical] ~104-~104: Il manque une espace après le point.
Context: ...ions ultérieures qui omettent ce champ.
PATCH /api/providers?name=<provider>acceptetrue,falseou ...(ESPACE_APRES_POINT)
[typographical] ~104-~104: Caractère d’apostrophe incorrect.
Context: .../api/providers?name=
acceptetrue,falseounull` pour effacer le remp...(APOS_INCORRECT)
📍 Affects 3 files
docs-site/src/content/docs/fr/reference/configuration/providers.md#L104-L104(this comment)docs-site/src/content/docs/ja/reference/configuration/providers.md#L92-L92docs-site/src/content/docs/zh-tw/reference/configuration/providers.md#L72-L72🤖 Prompt for AI Agents
Source: Path instructions