Skip to content

fix(claude): avoid creating agents directory when disabled #2619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lidge-jun merged 1 commit into from
Aug 25, 2026
Merged

fix(claude): avoid creating agents directory when disabled #2619

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/claude/agents-inject.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,14 @@ function isOwnedFile(path: string): boolean {
export function syncClaudeAgentDefs(defs: readonly ClaudeAgentDef[], configDir = claudeConfigDir()): string[] | null {
try {
const dir = join(configDir, "agents");
mkdirSync(dir, { recursive: true });
if (defs.length === 0) {
try { lstatSync(dir); } catch (error) {
if ((error as NodeJS.ErrnoException).code === "ENOENT") return [];
throw error;
}
} else {
mkdirSync(dir, { recursive: true });
}
const keep = new Set(defs.map(d => d.file));
for (const existing of readdirSync(dir)) {
if (!existing.startsWith(OWNED_PREFIX) || !existing.endsWith(".md")) continue;
Expand Down
8 changes: 7 additions & 1 deletion tests/claude-agents-inject.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { afterEach, describe, expect, test } from "bun:test";
import { mkdirSync, mkdtempSync, readdirSync, readFileSync, rmSync, symlinkSync, writeFileSync } from "node:fs";
import { existsSync, mkdirSync, mkdtempSync, readdirSync, readFileSync, rmSync, symlinkSync, writeFileSync } from "node:fs";
import { tmpdir } from "node:os";
import { join } from "node:path";
import { buildClaudeAgentDefs, injectClaudeAgentDefs, syncClaudeAgentDefs } from "../src/claude/agents-inject";
Expand Down Expand Up @@ -269,6 +269,12 @@ describe("buildClaudeAgentDefs (devlog 070 + audit 071)", () => {
});

describe("syncClaudeAgentDefs ownership contract (audit 071 #2/#3)", () => {
test("empty sync leaves an absent agents directory absent", () => {
const dir = tempDir();
expect(syncClaudeAgentDefs([], dir)).toEqual([]);
expect(existsSync(join(dir, "agents"))).toBe(false);
});

test("writes, overwrites, and prunes ONLY marker-verified ocx files", () => {
const dir = tempDir();
writeFileSync(join(dir, "settings.json"), JSON.stringify({ model: "claude-ocx-native--gpt-5.6-sol" }));
Expand Down
Loading