Repository navigation
fix(xai): stop advertising text.verbosity, including on combo and live-discovered rows (rebase of #2503) #2578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1127,6 +1127,17 @@ const configSchema = z.object({ | |
| message: reasoningSummariesError, | ||
| }); | ||
| } | ||
| const verbositySupportError = booleanRecordConfigError( | ||
| (provider as { modelSupportsVerbosity?: unknown }).modelSupportsVerbosity, | ||
| "modelSupportsVerbosity", | ||
| ); | ||
|
Comment on lines
+1130
to
+1133
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Although file loading now validates AGENTS.md reference: src/AGENTS.md:L20-L20 Useful? React with 👍 / 👎. |
||
| if (verbositySupportError) { | ||
| ctx.addIssue({ | ||
| code: "custom", | ||
| path: ["providers", redactSecretString(name), "modelSupportsVerbosity"], | ||
| message: verbositySupportError, | ||
| }); | ||
| } | ||
| const serviceTierModelsError = booleanRecordConfigError( | ||
| (provider as { modelSupportsServiceTier?: unknown }).modelSupportsServiceTier, | ||
| "modelSupportsServiceTier", | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When an xAI model ID arrives through live discovery and is absent from
XAI_MODELS, the catalog correctly inheritsProviderRegistryEntry.supportsVerbosity = false, butroutedProviderConfigsupplies the adapter only the enumeratedmodelSupportsVerbositymap. Consequently, if that discovered model is explicitly routed throughopenai-responses, this check seesundefinedand forwards a stale or direct caller'stext.verbosity, contradicting the final-wire guard described above it. Propagate the provider-wide default into the routed request policy or materialize the effective value for the routed model ID.AGENTS.md reference: src/AGENTS.md:L18-L18
Useful? React with 👍 / 👎.