Skip to content

[WRONG BRANCH] Merge dev into preview: ignore leftover test temp files - #1911

Merged
lidge-jun merged 3 commits into
previewfrom
promote-preview2
Aug 17, 2026
Merged

lidge-jun merged 3 commits into
previewfrom
promote-preview2

Conversation

@lidge-jun

@lidge-jun lidge-jun commented Aug 17, 2026 •

Copy link
Copy Markdown
Owner

Summary

tests/.tmp-*/ matched directories only. The same tests also leave plain files behind when a run dies mid-write, and on Windows an exiting child can still hold one open, so it cannot be deleted either. The result is an unignorable leftover that fails the release preflight's clean-tree check for work that has nothing to do with it.

Match both shapes: tests/.tmp-*.

Verification

  • git status --porcelain is clean with the two stranded tests/.tmp-codex-config-generation-* files present.
  • No test or build path reads .gitignore.

Checklist

  • Scope stays focused and avoids unrelated cleanup.
  • Docs or release notes were updated when needed.
  • Security-sensitive changes were reviewed for secrets, auth, and unsafe defaults.

Summary by CodeRabbit

  • Chores
    • Updated test artifact exclusions to cover both temporary files and directories.

lidge-jun and others added 3 commits August 17, 2026 18:58
`tests/.tmp-*/` matched directories only, but the same tests leave plain files
behind when a run dies mid-write. On Windows an exiting child can still hold one
open, so it cannot be deleted either -- an unignorable leftover that blocks the
release preflight's clean-tree check for work unrelated to it. Match both shapes.
chore: ignore leftover test temp files, not only directories
@lidge-jun
lidge-jun merged commit 844081d into preview Aug 17, 2026
8 of 10 checks passed
@coderabbitai

coderabbitai Bot commented Aug 17, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: b2f147b8-f055-471b-acae-36f141d99e22

📥 Commits

Reviewing files that changed from the base of the PR and between e25ec09 and 76e87cd.

📒 Files selected for processing (1)
  • .gitignore

📝 Walkthrough

Walkthrough

The .gitignore rule for test temporary artifacts now ignores both directories and plain files named tests/.tmp-*. Comments document the updated behavior.

Changes

Test Artifact Ignore

Layer / File(s) Summary
Update test artifact ignore rule
.gitignore
The tests/.tmp-*/ pattern changed to tests/.tmp-*, and comments document coverage for directory and file-shaped leftovers.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: ingwannu, wibias

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch promote-preview2

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

✅ Deterministic PR hygiene checks passed.

@github-actions github-actions Bot added the chore Maintenance, CI, tests, refactors, or build changes (not a user-facing bug or feature). label Aug 17, 2026
@github-actions github-actions Bot changed the title Merge dev into preview: ignore leftover test temp files [WRONG BRANCH] Merge dev into preview: ignore leftover test temp files Aug 17, 2026
@github-actions

github-actions Bot commented Aug 17, 2026 •

Copy link
Copy Markdown
Contributor

⏳ DRAFT

  • wrong target branch (preview); retarget to dev.

What to do

  • Retarget this PR to dev — all contributions go to dev.

Its title has been prefixed with [WRONG BRANCH].
Automatic draft conversion failed (token cannot change draft status). Please convert this pull request to a draft manually. The required enforce-target check will keep failing until every issue above is resolved.

@lidge-jun
lidge-jun deleted the promote-preview2 branch August 17, 2026 10:52
agentHits pushed a commit to agentHits/opencodex that referenced this pull request Sep 17, 2026
Merge dev into preview: ignore leftover test temp files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Maintenance, CI, tests, refactors, or build changes (not a user-facing bug or feature).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant