Dynamic Sequence Tracks #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hacked together a basic importance track by combining the Ruler and the BigWig tracks and passing the value from the bigwig file to the part that makes each sequence. Can be a little buggy especially on Safari, zooming in and out may fail due to sync issues (?). Need to look more into the numerical class to see how it handles scrolling/zooming etc. Other TODOs include converting to heatmap if sufficiently zoomed out, having a scale on the left side and adding options to change yscale etc.
- modified NumericalTrack into ImportanceNumericalTrack - support for tooltips as well as legend - heights seem to be calibrated, albeit by chance. In the ImportanceSequence.tsx file the scale_fac seems to work. Needs more checking. - Supports setting y axis min and max (but min<=0). - Turns into heatmap when zoomed out sufficiently. Controlled by MIN_X_WIDTH_PER_BASE in ImportanceSequence.tsx - Needs thorough cleanup of dangling code and unused variables. - Works well on Chrome. Safari has issues when panning/zooming in and out. - Some issues with the y axis legend going out of bounds and looking wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Daofeng and team
I'm making a PR for dynamic sequence tracks as discussed. Unfortunately, I wrote this code around 1.5 years back as a prototype and had no knowledge of javascript (and still don't) and am a bit foggy on the details. Thankfully there are some notes in the commit messages that you can read below. I mashed together different classes and somehow got it to work. The code is messy and has many unused imports in files. I've left some comments and debug statements around what seemed critical parts. Since it's based on an old version of the code, some formatting changes are not reflected in the files I am adding. However, I've merged in the latest master code so it's compatible.
It is buggy on Safari and the character heights are incorrectly updated when resizing or changing the window. But it works on Chrome and Edge.
At a high level, I believe I combined the RulerTrack and NumericalTrack to somehow pass numerical values and scale each character's height accordingly. I able to make the following observations on looking at this code recently:
BASE_SIZESis added and code is changed aroundif (baseWidth >= letterSize)linezeroLinevariable (Distance of y=0 from top)I really apologise for the messy code. Please let me know if you have any questions.
An example bigwig track with these dynamic sequence scores is here.