[Mobile] add bookmarked boolean to game json

[veloce]

Needed for lichess-org/mobile#594

Mobile PR: lichess-org/mobile#868

I see 3 places where we need this:

In the json returned by:

• GET /api/games/user/<username>
• GET /game/export/<gameId>

In mobile round socket:
https://github.com/lichess-org/lila/blob/master/modules/round/src/main/RoundMobile.scala

[Siderite]

Wouldn't that mean that the API would return different results based on the logged user?

[ornicar]

Wouldn't that mean that the API would return different results based on the logged user?

Yes, nothing wrong with that.

[ornicar]

mobile round socket JSON: 77ba6b0

[ornicar]

are we sure we want to display the bookmark status in game lists?

[veloce]

are we sure we want to display the bookmark status in game lists?

Not directly in the list, but I was thinking at the context menu (long press on an item), or a swipe to discover actions as we often find in mobile apps. (Un)Bookmark by swiping the game would make sense imo.

[ornicar]

Ah, then it's wasteful for the server to check for bookmarks for all games, all the time, when we only need to know after a user action?
Instead you could fetch /game/export when required?

[veloce]

I think we can do that yes. Especially for the context menu. Ideally for the swipe action we should know in advance but we're not obliged to implement swipe.

[ornicar]

then make sure to set the withBookmarked query parameter only when actually needed.