Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flock.band should handle a broader range of synths... #190

Open
the-t-in-rtf opened this issue Sep 20, 2016 · 3 comments
Open

flock.band should handle a broader range of synths... #190

the-t-in-rtf opened this issue Sep 20, 2016 · 3 comments

Comments

@the-t-in-rtf
Copy link
Contributor

As we discussed, the flock.band grade's getSynths method looks for child components that have the flock.synth grade. This notably excludes the polyphonic synth, which does not extend flock.synth. It would be better to:

  1. Target children with the flock.noteTarget grade instead
  2. Make the target grade(s) an option in flock.band.
  3. Remove the existing function in favor of an invoker that uses fluid.queryIoCSelector.

I will submit a quick PR that addresses this.
@the-t-in-rtf
Copy link
Contributor Author

I am starting by taking care of points 2 and 3 and confirming all tests still run. I will then make the primary change and rerun the tests.

@the-t-in-rtf
Copy link
Contributor Author

With the new invoker, we could also trivially set the default option to an array of grades that includes both flock.synth and flock.noteTarget.

the-t-in-rtf added a commit to the-t-in-rtf/Flocking that referenced this issue Sep 20, 2016
@the-t-in-rtf
lichen-community-systemsGH-190: Updated flock.band to use an invoker.
0b1bc4e
the-t-in-rtf added a commit to the-t-in-rtf/Flocking that referenced this issue Sep 20, 2016
@the-t-in-rtf
lichen-community-systemsGH-190: Updated flock.band to use `flock.no…
a7d8303 
…teTarget` as the target grade.
@the-t-in-rtf the-t-in-rtf mentioned this issue Sep 20, 2016
Merged
@the-t-in-rtf
Copy link
Contributor Author

It turns out I was optimistic about fluid.queryIoCSelector, which only supports a single grade. If we want to support an array of values, we'd need to add a function that iterates through them and compiles an array of distinct offerings.

colinbdclark added a commit that referenced this issue Dec 11, 2016
@colinbdclark
Merge branch 'master' into gh-190
40a2f57 
* master:
  gh-198: Adds additional documentation regarding support for npm 3.
  gh-198: Updates the Playground file paths to flat, npm 3 layout.
  gh-195: Updates documentation to reflect support for Node.js 6.x.
  Fixes gh-195: Updates to Node 6-compatible version of midi dep.
colinbdclark added a commit that referenced this issue Dec 11, 2016
@colinbdclark
gh-190: Updates built files.
3bc6f71
colinbdclark added a commit that referenced this issue Dec 11, 2016
@colinbdclark
Merge branch 'gh-190'
99ed819 
* gh-190:
  gh-190: Updates built files.
  GH-190: Updated `flock.band` to use `flock.noteTarget` as the target grade.
  GH-190: Updated `flock.band` to use an invoker.
colinbdclark added a commit that referenced this issue Dec 11, 2016
@colinbdclark
Merge branch 'master' into midi-improvements
2aebeee 
* master:
  gh-190: Updates built files.
  Fixes gh-200: Adds support for very short attack/decay times.
  GH-190: Updated `flock.band` to use `flock.noteTarget` as the target grade.
  GH-190: Updated `flock.band` to use an invoker.
colinbdclark added a commit that referenced this issue Dec 22, 2016
@colinbdclark
Merge remote-tracking branch 'origin/master' into unit-testing-improv…
317bf04 
…ements

* origin/master:
  Updates codemirror-infusion dependency
  Fixes gh-116: Renames midi-input-selector to midi-port-selector.
  Fixes gh-202: Fixes bug in playBuffer where the buffer didn't reset when re-triggered.
  gh-190: Updates built files.
  Fixes gh-200: Adds support for very short attack/decay times.
  gh-198: Updates midi examples to support npm 3.
  Fixes gh-193: Corrects the order of MSB and LSB when reading 14-bit MIDI values.
  GH-190: Updated `flock.band` to use `flock.noteTarget` as the target grade.
  GH-190: Updated `flock.band` to use an invoker.
  Adds support for receiving MIDI sysex messages.
  gh-169: Improves logging output of MIDI messages.
  Fixes gh-169: Factors midi logging into a reusable view component.
  gh-115: Adds support for selecting output ports to flock.ui.midiConnector. Basic, working raw MIDI send demo.
  gh-168: Adds support for all MIDI system messages except sysex and MTC.
  Splits flock.midi.controller out into its own file.
  Adds todo comments to midi.controller.
  Adds a way to send static values in a midi map. Additional comments for EnvGen.
  Adds support for multiple mappings for a MIDI single note or control.
  Adds an afterConnectionReady event to midiConnector. Ensures all midi-related IoC references correctly resolve.
  gh-169: Basic sketch of MIDI logging component, currently hardcoded into the midi demo.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@the-t-in-rtf