Create image from icon theme and adding a background to layout #88
Conversation
| @@ -10,6 +10,7 @@ | |||
| #include "YImage.h" | |||
| #include "ygtkimage.h" | |||
| #include <string.h> | |||
| #include <boost/filesystem.hpp> | |||
|
|
|||
| static inline bool endsWith (const std::string &str1, const char *str2) | |||
There was a problem hiding this comment.
JFYI: There is also boost::algorithm::ends_with() which might take some of the maintenance burden off your shoulders in the future.
https://techoverflow.net/2022/01/25/how-to-use-boost-string-algorithm-ends_with-a-minimal-example/
But it's your choice whether or not you want to use that.
I know those functions are a bit intimidating because they expect a range, and it's not quite clear to the average programmer how that works with strings. But as that example shows, it can be written in a very legible way.
|
Thanks, i was out yesterday and couldn't do it |
|
I was wondering if we need to give you permission to merge to that repository, and then I found that I don't seem to have permission to grant anybody permission. ;-) |
|
:) i can merge, but I need at least one reviewer, don't know if it is why i am the committer or just because one of you is needed... |
This PR just fixes issue #86 and #87