-
-
Notifications
You must be signed in to change notification settings - Fork 678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ICC transforms with XYZ PCS don't roundtrip correctly #3150
Comments
I did a little research and noticed that the bug has been reproducible since version 8.11.0. |
I did a little digging and I think the issue is that these two paths are not exactly equal:
ie. the lcms option to output xyz does not give exactly the same results as requesting lab, and then using the libvips lab2xyz. Perhaps lcms is using D50 lab, and libvips is using D65 lab? I'll try reading the lcms sources and see if I can find the formula they are using. |
It looks like passing |
I just opened PR #3368 for this. |
Avoids the need to pack the buffer of floats into lcms's fixed-point formats and ensures full precision internally in lcms. Resolves: libvips#3150. Supersedes: libvips#3368.
This works:
But this has a visible colour difference:
See libvips/php-vips#169
The text was updated successfully, but these errors were encountered: