Skip to content

Conversation

@czurnieden
Copy link
Contributor

First batch.
The functions are interdependent, they call each other in case of negative input.

@minad
Copy link
Member

minad commented Apr 3, 2019

Looks good except for the whitespace changes.

@czurnieden
Copy link
Contributor Author

czurnieden commented Apr 3, 2019

Looks good except for the whitespace changes.

But @sjaeckel was very nice and helped me to install a hook to…oh, that was only for that branch not for all. My bad, sorry.

I'm currently building the PR for mp_ilogb which won't need long (hopefully ;-) ) and clean up when that is done.

EDIT: @minad took a look at it. Run make astyle and got nothing about my functions but a bunch of files got formatted, files I didn't touch. Check in branch develop: up-to-date and the same reaction to astyle. What happened? Oh, and while we are at it: tried to use IS_ZEROin test.c but it includes tommath.h only, IS_ZERO is in tommath_private.h. What is the reason for that restriction?

@sjaeckel
Copy link
Member

sjaeckel commented Apr 4, 2019

which whitespace changes?

@sjaeckel
Copy link
Member

sjaeckel commented Apr 4, 2019

What is the reason for that restriction?

Tests should only use the public API. For your case there's still mp_iszero()... but I can also live with mp_cmd_d()

@sjaeckel
Copy link
Member

sjaeckel commented Apr 4, 2019

which whitespace changes?

@minad *ping*

@minad
Copy link
Member

minad commented Apr 4, 2019

@sjaeckel sjaeckel merged commit e6902c4 into libtom:develop Apr 4, 2019
@czurnieden czurnieden deleted the bn_incr branch April 7, 2019 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants