BugFix: FIX MIX_CreateSineWaveAudio(). #767
Open
+6
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sezero
reviewed
Sep 21, 2025
|
Let me see if we can reasonably make this work without making a dummy iostream before we merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MIX_CreateSineWaveAudio() has a bug: MIX_LoadAudioWithProperties() require MIX_PROP_AUDIO_LOAD_IOSTREAM_POINTER, but MIX_CreateSineWaveAudio() not set it, MIX_LoadAudioWithProperties always fail.
I set a dummy SDL_IOStream to walk around it , and it works.
PS: The current Unit Test only cover a little code, shall we write high cover Unit Test using GoogleTest?