Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve ability to debug failed surface comparisons #8316

Merged
merged 3 commits into from
Oct 5, 2023
Merged

Improve ability to debug failed surface comparisons #8316

merged 3 commits into from
Oct 5, 2023

Conversation

smcv
Copy link
Contributor

@smcv smcv commented Sep 29, 2023 •
edited
Loading

  • SDLTest_CompareSurfaces: Log better messages if NULL or different sizes
  • SDLTest_CompareSurfaces: If surfaces differ, log their formats
  • SDLTest_CompareSurfaces: Output RGBA values of first differing pixel

I used this to get better information out of #8315.

madebr
madebr reviewed Sep 29, 2023
View reviewed changes
src/test/SDL_test_compare.c Outdated Show resolved Hide resolved
@smcv smcv force-pushed the compare-surface-formats branch from 87be55a to 67a5fd1 Compare September 29, 2023 13:41
@smcv smcv force-pushed the compare-surface-formats branch from 67a5fd1 to e5b6009 Compare September 29, 2023 13:56
@slouken
Copy link
Collaborator

slouken commented Sep 29, 2023

These changes look good to me, thanks!

@smcv smcv requested a review from madebr October 5, 2023 10:13
@madebr madebr merged commit 4e59bf6 into libsdl-org:main Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madebr madebr Awaiting requested review from madebr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smcv @slouken @madebr