CMake: Require CMake 3.16+, Fix for recent iOS SDK #4274
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems |
Support CMake build with Xcode generator with: - Require CMake 3.16+ on APPLE to use OBJC language - enable_language(OBJC) and don't override them to C - Don't use find_library for frameworks as official cmake-toolchains(7) sugguests - Include `CheckOBJCSourceCompiles` for Apple platforms - Add a semicolon to feed correct source to `check_objc_source_compiles` - Add include path to khronos headers to ObjC sources
|
Hmm, consulting CMake source,
should not be needed and perhaps something wrong on my end.. Sorry for the noise and pull this for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build SDL library for iOS and its friends with stock CMake, without external toolchain file (ie. ios-cmake)
Description
OBJClanguageenable_language(OBJC)and don't override them toCfind_libraryfor frameworks as official cmake-toolchains(7) sugguestsCoreHapticsframework along with GameController becauseSDL_mfijoystick.mnow require itCheckOBJCSourceCompilesfor Apple platformscheck_objc_source_compilesAs adding
CoreHapticsto build dependency, now stock CMakeLists.txt require iOS 13+ and tvOS 14+ SDKs.