Add support for joystick LED for Switch controllers#14901
Merged
slouken merged 1 commit intolibsdl-org:mainfrom Jan 27, 2026
Merged
Add support for joystick LED for Switch controllers#14901slouken merged 1 commit intolibsdl-org:mainfrom
slouken merged 1 commit intolibsdl-org:mainfrom
Conversation
Co-Authored-By: Thiago Lelles Fernandes <125714191+thilelito@users.noreply.github.com>
Collaborator
|
Merged, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The idea was originally proposed and implemented by @ThiLelito in godotengine/godot#115114 , so we decided to make a PR for SDL too.
Since Switch 1 (and not Switch 2) Pro Controller and right JoyCon controllers have a home LED light, we think it makes sense for it to be also exposed via
SDL_SetJoystickLED()and not only through theSDL_JOYSTICK_HIDAPI_SWITCH_HOME_LEDhint in case a developer might want to change the brightness of the home LED on only one connected controller and not the other ones.